Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the price to verify native signatures #766

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Jun 15, 2024

closes: #757

Use secp256k1 instead of secp256r1 gas price when validating native signatures on UTXOs.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@Voxelot Voxelot self-assigned this Jun 15, 2024
@Voxelot Voxelot requested a review from a team June 15, 2024 01:58
@xgreenx xgreenx added the breaking A breaking api change label Jun 15, 2024
MitchTurner
MitchTurner previously approved these changes Jun 15, 2024
@Voxelot Voxelot marked this pull request as draft June 15, 2024 19:37
@Voxelot
Copy link
Member Author

Voxelot commented Jun 15, 2024

holding off on this due to potential backwards compatibility issues

@xgreenx xgreenx marked this pull request as ready for review October 5, 2024 18:19
@xgreenx xgreenx requested a review from Dentosal as a code owner October 5, 2024 18:19
@xgreenx xgreenx self-assigned this Oct 5, 2024
@Voxelot Voxelot added this pull request to the merge queue Oct 5, 2024
Merged via the queue into master with commit 77c9d9c Oct 5, 2024
40 checks passed
@Voxelot Voxelot deleted the bug/correct-native-sig-fee branch October 5, 2024 19:10
@xgreenx xgreenx mentioned this pull request Oct 5, 2024
@VolkovDAvan
Copy link

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect gas price for input signature verification
5 participants