Correct the price to verify native signatures (#766)

* use the correct pricing for checking native utxo signatures, secp256k1 price instead of secp256r1 cost * CHANGELOG.md * Fixed tests * Add breakign label --------- Co-authored-by: green <xgreenx9999@gmail.com>
FuelLabs · Oct 5, 2024 · 77c9d9c · 77c9d9c
1 parent 9693d43
commit 77c9d9c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 #### Breaking
 - [#843](https://github.com/FuelLabs/fuel-vm/pull/843): Remove `serde` feature from the `fuel-tx` crate. It is default behaviour now if you enable `alloc` feature.
+- [#766](https://github.com/FuelLabs/fuel-vm/pull/766): Use correct gas price when validating native signatures
 
 ### Changed
 

diff --git a/fuel-tx/src/transaction/fee.rs b/fuel-tx/src/transaction/fee.rs
@@ -257,7 +257,7 @@ pub trait Chargeable: field::Inputs + field::Witnesses + field::Policies {
                 // Charge EC recovery cost for signed inputs
                 Input::CoinSigned(_)
                 | Input::MessageCoinSigned(_)
-                | Input::MessageDataSigned(_) => gas_costs.ecr1(),
+                | Input::MessageDataSigned(_) => gas_costs.eck1(),
                 // Charge the cost of the contract root for predicate inputs
                 Input::CoinPredicate(CoinPredicate {
                     predicate,

diff --git a/fuel-vm/src/checked_transaction.rs b/fuel-vm/src/checked_transaction.rs
@@ -1269,7 +1269,7 @@ mod tests {
         let expected_min_fee = (tx.metered_bytes_size() as u64
             * fee_params.gas_per_byte()
             + gas_costs.vm_initialization().resolve(tx.size() as u64)
-            + 3 * gas_costs.ecr1()
+            + 3 * gas_costs.eck1()
             + gas_costs.s256().resolve(tx.size() as u64))
             * gas_price;
         assert_eq!(min_fee, expected_min_fee);
@@ -1323,7 +1323,7 @@ mod tests {
         let expected_min_fee = (tx.metered_bytes_size() as u64
             * fee_params.gas_per_byte()
             + gas_costs.vm_initialization().resolve(tx.size() as u64)
-            + gas_costs.ecr1()
+            + gas_costs.eck1()
             + gas_costs.s256().resolve(tx.size() as u64))
             * gas_price;
         assert_eq!(min_fee, expected_min_fee);
@@ -1475,7 +1475,7 @@ mod tests {
         let min_fee = fee.min_fee();
         let expected_min_fee = (tx.metered_bytes_size() as u64
             * fee_params.gas_per_byte()
-            + 3 * gas_costs.ecr1()
+            + 3 * gas_costs.eck1()
             + gas_costs.vm_initialization().resolve(tx.size() as u64)
             + gas_costs.contract_root().resolve(predicate_1.len() as u64)
             + gas_costs.contract_root().resolve(predicate_2.len() as u64)