chore: optimize tx fetching #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra0x3
force-pushed
the
rashad/288-optimize-tx-fetching
branch
from
f342d1b
to
743efa0
Compare
ra0x3
force-pushed
the
rashad/288-optimize-tx-fetching
branch
from
1a497c2
to
4373205
Compare
ra0x3
force-pushed
the
rashad/288-optimize-tx-fetching
branch
from
4373205
to
435ddb1
Compare
deekerno
approved these changes
Jun 2, 2023
| @@ -0,0 +1,102 @@ | |||
| use cynic::QueryBuilder; | |||
There was a problem hiding this comment.
We should make a tracking issue for making sure that all of this lands in fuel-core so we don't have duplicated code that's susceptible to drift. Not a blocker though.
There was a problem hiding this comment.
@deekerno feel free! You're right copying the code is just a temp solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BlockDatalooks like:BlockData { height: 28, id: 2007426b9299e10db4ff01d8d9045d002707bf398e200171bc6725e0b67a6a80, header: Header { id: 2007426b9299e10db4ff01d8d9045d002707bf398e200171bc6725e0b67a6a80, da_height: 8632717, transactions_count: 1, output_messages_count: 0, transactions_root: bd88b13585efa030b8b81256d7905418b2b58abba31c496426127be6c1dd4a4f, output_messages_root: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, height: 28, prev_root: 07115dec08253999e2e4c24bd20353f0731107d38858f24fa3a593c2505761fd, time: 1678485391, application_hash: c4889b20748aeebaa60dca18fa37e375667dafccfc0ba59eb3886d1ee290c5e2 }, producer: Some(f65d6448a273b531ee942c133bb91a6f904c7d7f3104cdaf6b9f7f50d3518871), time: 1678485391, consensus: PoA(PoA { signature: a8674e5fb86b32e98a903e1bc04d3484abde2dd93c815766fe4af4ab68eab4229ef47e1a668a4804dff1d9f9726b1800c2d98f1890e712db18fc8f2f13790bb3 }), transactions: [TransactionData { transaction: Script(Script { gas_price: 0, gas_limit: 0, maturity: 0, script: [], script_data: [], inputs: [], outputs: [], witnesses: [], receipts_root: 0000000000000000000000000000000000000000000000000000000000000000, metadata: None }), status: Success { block: 2007426b9299e10db4ff01d8d9045d002707bf398e200171bc6725e0b67a6a80, time: 1678485391, program_state: None }, receipts: [], id: c3a279eec0b298c36a28292197e7e09c6f5eebf40497f368c1aac81982c4f24a }] }Testing steps
Changelog