Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize transaction fetching #288

Closed
ra0x3 opened this issue Oct 27, 2022 · 2 comments · Fixed by #969
Closed

Optimize transaction fetching #288

ra0x3 opened this issue Oct 27, 2022 · 2 comments · Fixed by #969
Assignees
@ra0x3
Labels
fuel-explorer This PR is directly related to the block explorer
Milestone
Beta-4.5

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Oct 27, 2022

  • After Add basic usage example #279 the indexer will support fetching transactions using a Fuel GQL client
  • Currently, the fuel-indexer::service fetches transactions individually, iterating over each TransactionIdFragment included in a block's transactions (block.transactions)
  • We should optimize this functionality a bit by only making a single call using the client.transactions() (plural) API
  • The transactions returned by a transactions() call should be the same transactions that are included in block.transactions
@ra0x3 ra0x3 mentioned this issue Oct 28, 2022
Closed
15 tasks
@deekerno deekerno mentioned this issue Nov 9, 2022
Closed
@deekerno deekerno added the blocked This change is currently blocked by a linked issue label Dec 3, 2022
@ra0x3 ra0x3 mentioned this issue Dec 5, 2022
Closed
16 tasks
@deekerno
Copy link
Contributor

I'm currently working on an implementation of a separate endpoint on the client that returns blocks with full transactions included rather than their ID fragments.

@deekerno deekerno removed their assignment Jan 13, 2023
@ra0x3 ra0x3 added this to the Beta-4 milestone Jan 27, 2023
@ra0x3 ra0x3 removed the blocked This change is currently blocked by a linked issue label Apr 21, 2023
@ra0x3 ra0x3 modified the milestones: Beta-4, Beta-4.5 May 3, 2023
@ra0x3 ra0x3 added the fuel-explorer This PR is directly related to the block explorer label May 8, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented May 14, 2023

FuelLabs/fuel-core#1175

@ra0x3 ra0x3 self-assigned this May 15, 2023
@deekerno deekerno mentioned this issue Jun 1, 2023
Closed
@ra0x3 ra0x3 linked a pull request Jun 2, 2023 that will close this issue
chore: optimize tx fetching #969
Merged
4 tasks
@xgreenx xgreenx mentioned this issue Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ra0x3 ra0x3

Labels
fuel-explorer This PR is directly related to the block explorer
Projects
None yet
Milestone
Beta-4.5
Development

Successfully merging a pull request may close this issue.

chore: optimize tx fetching FuelLabs/fuel-indexer
2 participants
@deekerno @ra0x3