Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add find_many #1469

Merged
merged 13 commits into from
Nov 29, 2023
Merged

enhancement: add find_many #1469

merged 13 commits into from
Nov 29, 2023

Conversation

lostman
Copy link
Contributor

@lostman lostman commented Nov 22, 2023 •
edited
Loading

Description

Closes #1467.

This PR adds the find_many() function to the Entity trait, which is like find(), except that it fetches multiple results.

Testing steps

CI tests should pass. This PR adds basic find_many tests to the existing find test.

Changelog

  • Add find_many to the Entity trait.
  • Rename QueryFragment to OrderedFilter. This way we have Filter and OrderedFilter, which easier to understand.
  • Clean up some implementation details.

@lostman lostman self-assigned this Nov 22, 2023
@lostman lostman marked this pull request as ready for review November 22, 2023 18:06
ra0x3
ra0x3 suggested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lostman

  • Left feedback regarding the usage of limit in your find_many implementation
  • Will review again once that's fixed (since I think fixing that will shift some logic around)

packages/fuel-indexer-plugin/src/wasm.rs Outdated Show resolved Hide resolved
@lostman lostman requested a review from ra0x3 November 28, 2023 14:00
ra0x3
ra0x3 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lostman

@lostman lostman merged commit ba28add into develop Nov 29, 2023
19 checks passed
@lostman lostman deleted the maciej/1467-find-many-v2 branch November 29, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deekerno deekerno deekerno approved these changes

@ra0x3 ra0x3 ra0x3 approved these changes

Assignees

@lostman lostman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement .find_many() on Entity
3 participants
@lostman @deekerno @ra0x3