Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .find_many() on Entity #1467

Closed
ra0x3 opened this issue Nov 16, 2023 · 0 comments · Fixed by #1469
Closed

Implement .find_many() on Entity #1467

ra0x3 opened this issue Nov 16, 2023 · 0 comments · Fixed by #1469
Assignees

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Nov 16, 2023

  • With the completion of Implement .find() on Entity #1437 we now have .find() usage
  • The next thing we want is the implementation of .find_many()
  • .find_many() would work just like .find() except it instead of returning Option<Entity> it would return Option<Vec<Entity>>
  • We would have to establish some constraints/parameters around the size of the result set of .find_many()
    • Since we allocate space in the runtime for the result of .find() (and .get()) we would need to set some max size that can be allocated for .find_many() results
      • Maybe this is configurable?
@ra0x3 ra0x3 changed the title Implement .find_many on Entity Implement .find_many() on Entity Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants