-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ui impovement for the volume controls #2225
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@amitanshusahu Heya! Almost there, idea with keeping text short is to include it on the button itself. |
oh i get it.. my bad i didn't update the master.. and taking about the text inside the button .. that would need a custom component to be made with html, css & js.. because these is no other way of doing it with just css.. alternatively we can design the button as an png and use it something like this #sfx::-webkit-slider-thumb {
-webkit-appearance: none;
appearance: none;
width: 23px;
height: 24px;
border: 0;
background: url('button.png'); / * using the designed image here */
} if you agree with this i can push the changes .. |
@amitanshusahu Understood. Quickly searched around and seen a scenario where a generated svg was used ;) https://stackoverflow.com/questions/68033352/using-an-svg-as-a-css-background-image-on-input-range-thumb |
Merging this as it is, because I've figured how to integrate the sliders better within the player soon based on #2227 etc. |
@amitanshusahu Bounty 🪙 sent -> https://www.mintme.com/explorer/tx/0xf13055c11b46a2ef2faf750074789645590146d0cbf3aabb0ed63e464e8d2e70 Feel free to poke at other issues as well 😎 |
This fixes issue #2180
My wallet address is 0x35e866D1C52DACBA5275Ddb01637B1e19ce902B1
Screenshots of the changes