Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music player integrated volume and sfx sliders [bounty: 8 XTR] #2228

Open
DreadKnight opened this issue Apr 20, 2023 · 6 comments
Open

music player integrated volume and sfx sliders [bounty: 8 XTR] #2228

DreadKnight opened this issue Apr 20, 2023 · 6 comments
Labels
audio This involves sfx, voice acting or composing bounty Some amount of our token, XatteR, is offered coding This issue requires some programming input Deals with hotkeys, interaction & accessibility visuals Various things that easily catch the eye

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Apr 20, 2023

In the Audio page (Shift+A), the Volume slider (VOL) and Sound Effects (SFX) should be integrated into the music player, following the styling of the seeker bar and located to the left and right side of the beast head, using VOL and SFX text.

This should be implemented after issue #2227 has been fixed, in order to have space and avoid any coding conflicts.

@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye audio This involves sfx, voice acting or composing input Deals with hotkeys, interaction & accessibility bounty Some amount of our token, XatteR, is offered labels Apr 20, 2023
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone Apr 20, 2023
@DreadKnight DreadKnight changed the title proper Volume slider in audio page [bounty: 4 XTR] integrated volume and sfx sliders [bounty: 8 XTR] Apr 20, 2023
@DreadKnight DreadKnight changed the title integrated volume and sfx sliders [bounty: 8 XTR] music player integrated volume and sfx sliders [bounty: 8 XTR] Apr 20, 2023
@chimpirilin
Copy link
Contributor

@DreadKnight I'll work on this.

@DreadKnight
Copy link
Member Author

@DreadKnight I'll work on this.

@chimpirilin Alright, assigned.

@DreadKnight
Copy link
Member Author

@chimpirilin Heya! Any progress with this? Usually the soft-deadline is 2 weeks, it's been double that 🐻

@chimpirilin
Copy link
Contributor

@DreadKnight Sorry, I overlooked this issue.
Will start to work on it.

@u7486259
Copy link
Contributor

Hi @DreadKnight I'm interested in this issue, just wondering if there currently is meant to be a volume slider present in the game at present? Or is it currently meant to be part of the SFX slider (seems to only adjust the SFX not music volume).

@DreadKnight
Copy link
Member Author

DreadKnight commented Oct 22, 2023

@u7486259 The music volume slider used to be integrated by default in the old music player; now it should be added again, according to specs. I've assigned you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio This involves sfx, voice acting or composing bounty Some amount of our token, XatteR, is offered coding This issue requires some programming input Deals with hotkeys, interaction & accessibility visuals Various things that easily catch the eye
Projects
None yet
Development

No branches or pull requests

3 participants