Added New Window option to Tray

[Devenor]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Adds #7049 functionality to the Tray

Description

Tray menu option enabling to open a new Freetube instance.

Screenshots

Testing

When clicking the New Window option, a new window opens. Other windows hidden in the tray must remain there.

Desktop

• OS: Windows, Linux
• OS Version: Windows 10, Ubuntu 22.04.3 LTS
• FreeTube version: 0.23.8 Beta

Additional context

[Devenor]

Done, but I was thinking that when the main window is hidden to the tray and there are other visible windows, none of them become the main window. Should I change that too?

[absidue]

If it is easy to do, sure, if not then it would be better to leave it for a separate pull request.

[Devenor]

I've added the following:

• When all windows are hidden, the first one to be shown becomes the new main window.
• If the main window is hidden, the one that has the focus becomes the new main window.
• If no window has the focus (for example if they are behind another app), the last opened window becomes the new main window.

Seems to work fine. My only concern is about the timer in Linux, it works in my distro, but we might need to increase it a bit if it's not enough in others.

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Hi @Devenor apologies for the delay. Past weeks were a bit hectic because we needed to adapt to YouTube's changes to get playback to unbreak.

Anyway i tested the PR and it looks good.

I've added the following:

• When all windows are hidden, the first one to be shown becomes the new main window.
• If the main window is hidden, the one that has the focus becomes the new main window.
• If no window has the focus (for example if they are behind another app), the last opened window becomes the new main window.

Seems to work fine. My only concern is about the timer in Linux, it works in my distro, but we might need to increase it a bit if it's not enough in others.

Could you maybe elaborate how i should test these changes

[Devenor]

Hey @efb4f5ff-1298-471a-8973-3d47447115dc , no worries, I imagined you'd be busy!

If you've tested the PR in all your distros and it works, it should be fine as it is. I just wanted to make sure because I had to add a small delay to check if another window has the focus after minimizing the main one, and we had some issues when using a timer on Linux in my first PR (the occasional flicker, if you still remember)

In any case, if the timer were too short, the only thing that could happen is that the new main window would become the first visible one found, which may or may not be the one that has the focus.