Update to Vue 3 #8094
Open
Update to Vue 3 #8094
+525
−692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
PR: dependencies
|
Is the plan to remove the 'composables/use-i18n-polyfill' in a follow up PR? |
|
Cannot remove videos from playlist |
Migrating to the actual composition API version of vue-i18n is planned in a follow up yes, as we still have some components in the options API format and those would need to be migrated to the composition API first. |
|
@PikachuEXE Fixed removing videos from playlists, also noticed that toasts weren't showing up so I fixed that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
After working on this on and off for years, with lots of prior pull requests paving the way, we can finally upgrade to Vue 3. Only 1.75 years after the Vue 2 became EOL and 6 days after the Vue language tools dropped support for Vue 3.
While a lot of work was already done in previous pull requests, this one does includes major version bumps for Vue, portal-vue, vue-i18n, vue-router, vuex, vue-loader and @fontawesome/vue-fontawesome, so I would suggest that we daily drive these changes for a bit to test them properly before merging them.
Testing
Test everything!
I would suggest including these changes in the builds that you use day-to-day.
Desktop