Fix playlist item fetching for local API #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
github-actions
bot
added
the
PR: waiting for review
|
For non dev to test this |
|
I'm curious why you decided to go with a callback instead of just returning all the results? |
|
Similar to I think in Ruby more than JS |
|
Mainly curious why you decided to use a callback, instead of collecting it in an array and returning it all in one go? |
absidue
approved these changes
Oct 6, 2023
| videos.push(...parsedVideos) | ||
| } | ||
| const videos = [] | ||
| await untilEndOfLocalPlayList(playlist, (p) => { |
There was a problem hiding this comment.
Using promises and callbacks together is a weird code pattern, which I'm not a fan of (the whole point of async/await in javascript was to get away from callbacks), but as we are in a rush and the code works, i'll accept it this time.
ChunkyProgrammer
approved these changes
Oct 7, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 7, 2023
github-actions
bot
removed
the
PR: waiting for review
6 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 8, 2023
* development: ! Fix playlist item fetching for local API (FreeTubeApp#4102) ! Fix watch page video published time parsing (FreeTubeApp#4105) Translated using Weblate (Serbian) Bump youtubei.js from 6.4.0 to 6.4.1 (FreeTubeApp#4090) Bump rimraf from 5.0.1 to 5.0.5 (FreeTubeApp#4091) Bump the stylelint group with 2 updates (FreeTubeApp#4088) Bump electron from 22.3.24 to 22.3.25 (FreeTubeApp#4089) Translated using Weblate (Bulgarian) Update FT history import to accept key lastViewedPlaylistId (FreeTubeApp#4038) Translated using Weblate (Dutch) Translated using Weblate (Lithuanian) Translated using Weblate (Japanese) Translated using Weblate (Croatian) Translated using Weblate (Estonian) Translated using Weblate (Croatian) # Conflicts: # src/renderer/components/data-settings/data-settings.js # src/renderer/components/ft-list-video/ft-list-video.js # src/renderer/components/watch-video-info/watch-video-info.js # src/renderer/views/Playlist/Playlist.js # src/renderer/views/Watch/Watch.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 8, 2023
* feature/playlist-2023-05: (176 commits) ! Fix playlist item fetching for local API (FreeTubeApp#4102) ! Fix watch page video published time parsing (FreeTubeApp#4105) Translated using Weblate (Serbian) Bump youtubei.js from 6.4.0 to 6.4.1 (FreeTubeApp#4090) Bump rimraf from 5.0.1 to 5.0.5 (FreeTubeApp#4091) Bump the stylelint group with 2 updates (FreeTubeApp#4088) Bump electron from 22.3.24 to 22.3.25 (FreeTubeApp#4089) Translated using Weblate (Bulgarian) Update FT history import to accept key lastViewedPlaylistId (FreeTubeApp#4038) ! Fix ft-video having different URLs in links Translated using Weblate (Dutch) Translated using Weblate (Lithuanian) Translated using Weblate (Japanese) Translated using Weblate (Croatian) Translated using Weblate (Estonian) Translated using Weblate (Croatian) ! Fix external player handling for video in local playlist Translated using Weblate (Finnish) Mobile/tablet channel page & share button visual improvements (FreeTubeApp#4061) Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator (FreeTubeApp#3942) ...
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #4068 #4086
Description
YT now sometimes returns useless continuation data which makes loading "next page" sometimes failed with error from
youtube.jsWe need to handle it somehow
Screenshots
Lazy
Testing
Example playlists/video with playlists to test
Watch video page, playlist component loading (normal)
Watch video page, playlist component loading (playlist cached)
Playlist view
Desktop
Additional context