Skip to content

Add config option for event groups and stream buffers #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 27, 2024

Conversation

kar-rahul-aws
Copy link
Member

Description

This PR adds config option for event group and stream buffer functionality.

  1. Set configUSE_STREAM_BUFFERS = 1 to enable stream buffers.
  2. Set configUSE_EVENT_GROUPS = 1 to enable event groups.

Test Steps

MPU demo on STM32H743ZI builds and runs successfully.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner February 14, 2024 19:35
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 82.38342% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 93.00%. Comparing base (39dbff7) to head (cea8ec8).

Files Patch % Lines
event_groups.c 82.38% 10 Missing and 24 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files           6        6           
  Lines        3200     3200           
  Branches      879      879           
=======================================
  Hits         2976     2976           
  Misses        111      111           
  Partials      113      113           
Flag Coverage Δ
unittests 93.00% <82.38%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kar-rahul-aws kar-rahul-aws marked this pull request as draft March 11, 2024 10:26
@kar-rahul-aws kar-rahul-aws marked this pull request as ready for review March 11, 2024 10:33
joshzarr
joshzarr previously approved these changes Mar 15, 2024
paulbartell
paulbartell previously approved these changes Mar 15, 2024
@kstribrnAmzn
Copy link
Member

Why are there no testing details for this change? You changes to event_groups.c has less than 90% coverage. Are you planning on adding unit test changes here?

@kar-rahul-aws
Copy link
Member Author

kar-rahul-aws commented Mar 16, 2024

I will add the unit test coverage for the file event_groups.c once this PR is merged.

kar-rahul-aws and others added 2 commits March 18, 2024 12:02
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg dismissed stale reviews from joshzarr and paulbartell via 8305bb9 March 18, 2024 07:22
aggarg
aggarg previously approved these changes Mar 18, 2024
joshzarr
joshzarr previously approved these changes Mar 20, 2024
@kar-rahul-aws kar-rahul-aws dismissed stale reviews from joshzarr and aggarg via 655ba88 March 26, 2024 06:11
aggarg
aggarg previously approved these changes Mar 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kar-rahul-aws kar-rahul-aws merged commit e8289df into FreeRTOS:main Mar 27, 2024
@kar-rahul-aws kar-rahul-aws deleted the update_mpu_wrappers branch March 27, 2024 09:20
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* Add IPv6 Demo (FreeRTOS#937)

* Add demo changes

* Update kernel and library paths

* Update main.c

* Run uncrustify

* Fix spell checker

* CI check file headers update

* Add IPv6/v4 UDP echo server with zero copy/non-zero copy versions

* Add VS proj file changes to include the UDP echo sample code

* readme update

---------

Co-authored-by: Tony Josi <tonyjosi@amazon.com>

* Update Backward Compatibility Flag (FreeRTOS#954)

* Update Backward Compatibility Flag

* Update FreeRTOS_GetUDPPayloadBuffer_ByIPType

* Update FreeRTOS_IPStart to FreeRTOS_IPInit_Multi

* Update Application APIs

* Remove ipconfigCOMPATIBLE_WITH_SINGLE

* Update Static Lib files (FreeRTOS#956)

* Update Static Lib files

* making vApplicationIPNetworkEventHook backward compatible in demos

* Update CI check file headers

---------

Co-authored-by: Tony Josi <tonyjosi@amazon.com>

* Add WinPCap NetworkInterface Changes (FreeRTOS#958)

* Update winpcap network interface

* Run uncrustify

* Update function to include NetworkInterface_t parameters

* Adding compatibility for xApplicationDNSQueryHook with latest dev branch for old demos (FreeRTOS#957)

* adding compatibility for xApplicationDNSQueryHook with latest dev branch

* adding tcp echo server source

* removing unused sub demos

* fix build issues (FreeRTOS#969)

* Update demo to latest +TCP dev/IPv6_integration (FreeRTOS#978)

* remove macro namings

* rename sin_addr to sin_address.ulIP_IPv4 for ipv6 demo

* replace in6addr_any with FreeRTOS_in6addr_any

* replace mainCREATE_UDP_ECHO_SERVER_TASK with mainCREATE_UDP_ECHO_TASKS_SINGLE

* handle removal of sin_addr macro to sin_address.ulIP_IPv4

* updating +TCP repo to latest dev/IPv6_integration

* minor update to more clear code

* more sin_addr to sin_address.ulIP_IPv4 replacements

* fix makefiles for qemu and posix demos

* review feedback changes

* Update FreeRTOS-Plus-TCP for RC2

* Change from PR (FreeRTOS#994)

* Update FreeRTOS-Plus-TCP for RC2

* Update copyright

* Ignore WinPCap for files header check failure.

* Update checker

* Update manifest

* Point manifest to latest commit

* Fix Spell-checker

* Update doxygen

* Update xApplicationDHCPHook for backward compatibility  (FreeRTOS#999)

* Update xApplicationDHCPHook for backward compatability

* Update IPv6

* Update VisualStudio Static Project files

* Update pxEndPoint error (FreeRTOS#1002)

* Update IPv6 demo ReadMe (FreeRTOS#1004)

* Update ReadMe

* Update setup requirement

* Update UDP demo info

* Update comment

* TCP demo changes post build separation (FreeRTOS#1011)

* adding sin_family to dest adddr for FreeRTOS_sendto

* updating FreeRTOS_bind to input sin_family post build separation changes

* updating FreeRTOS_connect to input sin_family post build separation changes

* minor fix

* updating copyright year

* updating file headers

* updating +TCP submodule

* updating file headers

* updating file headers

* updating manifest file to have latest +TCP submodule hash

* Fix issue with posix demo while running with ipconfigIPv4_BACKWARD_COMPATIBLE enabled for +TCP stack (FreeRTOS#1027)

* Update the submodule pointer to IPv6 main

* Update manifest with latest TCP commit

* Update file checker exception

* Ignore Visual studio project file from file header checker

---------

Co-authored-by: Tony Josi <tonyjosi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants