Skip to content

Commit 3bf9afe

Browse files
Skptakkar-rahul-aws
Skptak
authored and
kar-rahul-aws
committed
Code review suggestions
1 parent 655ba88 commit 3bf9afe

File tree

14 files changed

+171
-336
lines changed

14 files changed

+171
-336
lines changed

‎portable/ARMv8M/non_secure/portable/GCC/ARM_CM23/mpu_wrappers_v2_asm.c

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1705,12 +1705,11 @@
17051705
" mrs r0, control \n"
17061706
" movs r1, #1 \n"
17071707
" tst r0, r1 \n"
1708+
" pop {r0, r1} \n"
17081709
" bne MPU_xEventGroupWaitBits_Unpriv \n"
17091710
" MPU_xEventGroupWaitBits_Priv: \n"
1710-
" pop {r0, r1} \n"
17111711
" b MPU_xEventGroupWaitBitsImpl \n"
17121712
" MPU_xEventGroupWaitBits_Unpriv: \n"
1713-
" pop {r0, r1} \n"
17141713
" svc %0 \n"
17151714
" \n"
17161715
: : "i" ( SYSTEM_CALL_xEventGroupWaitBits ) : "memory"
@@ -1737,12 +1736,11 @@
17371736
" mrs r0, control \n"
17381737
" movs r1, #1 \n"
17391738
" tst r0, r1 \n"
1739+
" pop {r0, r1} \n"
17401740
" bne MPU_xEventGroupClearBits_Unpriv \n"
17411741
" MPU_xEventGroupClearBits_Priv: \n"
1742-
" pop {r0, r1} \n"
17431742
" b MPU_xEventGroupClearBitsImpl \n"
17441743
" MPU_xEventGroupClearBits_Unpriv: \n"
1745-
" pop {r0, r1} \n"
17461744
" svc %0 \n"
17471745
" \n"
17481746
: : "i" ( SYSTEM_CALL_xEventGroupClearBits ) : "memory"
@@ -1769,12 +1767,11 @@
17691767
" mrs r0, control \n"
17701768
" movs r1, #1 \n"
17711769
" tst r0, r1 \n"
1770+
" pop {r0, r1} \n"
17721771
" bne MPU_xEventGroupSetBits_Unpriv \n"
17731772
" MPU_xEventGroupSetBits_Priv: \n"
1774-
" pop {r0, r1} \n"
17751773
" b MPU_xEventGroupSetBitsImpl \n"
17761774
" MPU_xEventGroupSetBits_Unpriv: \n"
1777-
" pop {r0, r1} \n"
17781775
" svc %0 \n"
17791776
" \n"
17801777
: : "i" ( SYSTEM_CALL_xEventGroupSetBits ) : "memory"
@@ -1805,12 +1802,11 @@
18051802
" mrs r0, control \n"
18061803
" movs r1, #1 \n"
18071804
" tst r0, r1 \n"
1805+
" pop {r0, r1} \n"
18081806
" bne MPU_xEventGroupSync_Unpriv \n"
18091807
" MPU_xEventGroupSync_Priv: \n"
1810-
" pop {r0, r1} \n"
18111808
" b MPU_xEventGroupSyncImpl \n"
18121809
" MPU_xEventGroupSync_Unpriv: \n"
1813-
" pop {r0, r1} \n"
18141810
" svc %0 \n"
18151811
" \n"
18161812
: : "i" ( SYSTEM_CALL_xEventGroupSync ) : "memory"
@@ -1901,12 +1897,11 @@
19011897
" mrs r0, control \n"
19021898
" movs r1, #1 \n"
19031899
" tst r0, r1 \n"
1900+
" pop {r0, r1} \n"
19041901
" bne MPU_xStreamBufferSend_Unpriv \n"
19051902
" MPU_xStreamBufferSend_Priv: \n"
1906-
" pop {r0, r1} \n"
19071903
" b MPU_xStreamBufferSendImpl \n"
19081904
" MPU_xStreamBufferSend_Unpriv: \n"
1909-
" pop {r0, r1} \n"
19101905
" svc %0 \n"
19111906
" \n"
19121907
: : "i" ( SYSTEM_CALL_xStreamBufferSend ) : "memory"
@@ -1937,12 +1932,11 @@
19371932
" mrs r0, control \n"
19381933
" movs r1, #1 \n"
19391934
" tst r0, r1 \n"
1935+
" pop {r0, r1} \n"
19401936
" bne MPU_xStreamBufferReceive_Unpriv \n"
19411937
" MPU_xStreamBufferReceive_Priv: \n"
1942-
" pop {r0, r1} \n"
19431938
" b MPU_xStreamBufferReceiveImpl \n"
19441939
" MPU_xStreamBufferReceive_Unpriv: \n"
1945-
" pop {r0, r1} \n"
19461940
" svc %0 \n"
19471941
" \n"
19481942
: : "i" ( SYSTEM_CALL_xStreamBufferReceive ) : "memory"
@@ -1967,12 +1961,11 @@
19671961
" mrs r0, control \n"
19681962
" movs r1, #1 \n"
19691963
" tst r0, r1 \n"
1964+
" pop {r0, r1} \n"
19701965
" bne MPU_xStreamBufferIsFull_Unpriv \n"
19711966
" MPU_xStreamBufferIsFull_Priv: \n"
1972-
" pop {r0, r1} \n"
19731967
" b MPU_xStreamBufferIsFullImpl \n"
19741968
" MPU_xStreamBufferIsFull_Unpriv: \n"
1975-
" pop {r0, r1} \n"
19761969
" svc %0 \n"
19771970
" \n"
19781971
: : "i" ( SYSTEM_CALL_xStreamBufferIsFull ) : "memory"
@@ -1997,12 +1990,11 @@
19971990
" mrs r0, control \n"
19981991
" movs r1, #1 \n"
19991992
" tst r0, r1 \n"
1993+
" pop {r0, r1} \n"
20001994
" bne MPU_xStreamBufferIsEmpty_Unpriv \n"
20011995
" MPU_xStreamBufferIsEmpty_Priv: \n"
2002-
" pop {r0, r1} \n"
20031996
" b MPU_xStreamBufferIsEmptyImpl \n"
20041997
" MPU_xStreamBufferIsEmpty_Unpriv: \n"
2005-
" pop {r0, r1} \n"
20061998
" svc %0 \n"
20071999
" \n"
20082000
: : "i" ( SYSTEM_CALL_xStreamBufferIsEmpty ) : "memory"
@@ -2027,12 +2019,11 @@
20272019
" mrs r0, control \n"
20282020
" movs r1, #1 \n"
20292021
" tst r0, r1 \n"
2022+
" pop {r0, r1} \n"
20302023
" bne MPU_xStreamBufferSpacesAvailable_Unpriv \n"
20312024
" MPU_xStreamBufferSpacesAvailable_Priv: \n"
2032-
" pop {r0, r1} \n"
20332025
" b MPU_xStreamBufferSpacesAvailableImpl \n"
20342026
" MPU_xStreamBufferSpacesAvailable_Unpriv: \n"
2035-
" pop {r0, r1} \n"
20362027
" svc %0 \n"
20372028
" \n"
20382029
: : "i" ( SYSTEM_CALL_xStreamBufferSpacesAvailable ) : "memory"
@@ -2057,12 +2048,11 @@
20572048
" mrs r0, control \n"
20582049
" movs r1, #1 \n"
20592050
" tst r0, r1 \n"
2051+
" pop {r0, r1} \n"
20602052
" bne MPU_xStreamBufferBytesAvailable_Unpriv \n"
20612053
" MPU_xStreamBufferBytesAvailable_Priv: \n"
2062-
" pop {r0, r1} \n"
20632054
" b MPU_xStreamBufferBytesAvailableImpl \n"
20642055
" MPU_xStreamBufferBytesAvailable_Unpriv: \n"
2065-
" pop {r0, r1} \n"
20662056
" svc %0 \n"
20672057
" \n"
20682058
: : "i" ( SYSTEM_CALL_xStreamBufferBytesAvailable ) : "memory"
@@ -2089,12 +2079,11 @@
20892079
" mrs r0, control \n"
20902080
" movs r1, #1 \n"
20912081
" tst r0, r1 \n"
2082+
" pop {r0, r1} \n"
20922083
" bne MPU_xStreamBufferSetTriggerLevel_Unpriv \n"
20932084
" MPU_xStreamBufferSetTriggerLevel_Priv: \n"
2094-
" pop {r0, r1} \n"
20952085
" b MPU_xStreamBufferSetTriggerLevelImpl \n"
20962086
" MPU_xStreamBufferSetTriggerLevel_Unpriv: \n"
2097-
" pop {r0, r1} \n"
20982087
" svc %0 \n"
20992088
" \n"
21002089
: : "i" ( SYSTEM_CALL_xStreamBufferSetTriggerLevel ) : "memory"
@@ -2119,12 +2108,11 @@
21192108
" mrs r0, control \n"
21202109
" movs r1, #1 \n"
21212110
" tst r0, r1 \n"
2111+
" pop {r0, r1} \n"
21222112
" bne MPU_xStreamBufferNextMessageLengthBytes_Unpriv \n"
21232113
" MPU_xStreamBufferNextMessageLengthBytes_Priv: \n"
2124-
" pop {r0, r1} \n"
21252114
" b MPU_xStreamBufferNextMessageLengthBytesImpl \n"
21262115
" MPU_xStreamBufferNextMessageLengthBytes_Unpriv: \n"
2127-
" pop {r0, r1} \n"
21282116
" svc %0 \n"
21292117
" \n"
21302118
: : "i" ( SYSTEM_CALL_xStreamBufferNextMessageLengthBytes ) : "memory"

0 commit comments

Comments
 (0)