Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare version 1.5.7 #1349

Merged
merged 1 commit into from
May 6, 2020
Merged

Prepare version 1.5.7 #1349

merged 1 commit into from
May 6, 2020

Conversation

campersau
Copy link
Collaborator

@campersau campersau commented May 5, 2020

Fixed

  • Init tooltips from the app start #1343
  • Fixing some accessibility issues #1318
  • Flatten total-lines-changed object #1330
  • Set electron window icon explicitly so it works during debug and on linux #1347

Changed

  • Only display ref search button when there are hidden refs #1311, #1325
  • Cleanup CSS styles #1339, #1328, #1331, #1332, #1322
  • Style autocompletes like dropdowns #1327
  • Optimizes ref-search autocomplete initialization #1326
  • Reduce jQuery UI imports and use Bootstrap tooltips #1340
  • Image cleanup #1345
  • Bump Dependencies #1309

Removed

  • Remove unused color dependency #1341
  • Remove image embed #1346
  • Remove unused tracker.js #1344

Thanks @Hirse, @ylecuyer, @bakkerthehacker, @jung-kim !

Here is my current plan:

@wmertens
Copy link
Contributor

wmertens commented May 5, 2020

Regarding the Promise move:

@Hirse
Copy link
Contributor

Hirse commented May 5, 2020

@campersau the list looks good to me.

I'll update the icons in #1345. Do you remember what service you used to create the icns file?
I updated the electron icons in #1345 and also updated the favicon.

@Hirse
Copy link
Contributor

Hirse commented May 5, 2020

@wmertens Is the first link a tool to migrate the code? I think the codebase is small enough to handle it manually.

Secondly, since node 10, node has a native fs Promises API: fs.promises

@wmertens
Copy link
Contributor

wmertens commented May 6, 2020

@Hirse indeed, an automated tool, and it's much faster than doing it manually. The idea is to run it and then verify.

I always grab fs-extra for the helpers, but indeed in this case the fs.promises are sufficient

@campersau
Copy link
Collaborator Author

Yes, in addition to moving to native promises we can also refactor the code to use async / await afterwards. I actually had that as the last point after prettier but removed it because I hadn't checked browser support at that time.
Using the tool @wmertens mentioned is a good start but we definitely have to check the code manually because we currently use some syntax which I also want to get rid of like #1336 (comment)

Thanks @Hirse for the fs.promises hint, I had used util.promisify(fs.api) in my bluebird removal branch andI will replace that before I create the PR.

@campersau campersau force-pushed the release branch 2 times, most recently from af3f97b to 71d622b Compare May 6, 2020 13:05
@campersau campersau merged commit 7b40061 into FredrikNoren:master May 6, 2020
@campersau campersau deleted the release branch May 6, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants