Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some accessibility issues #1318

Merged
merged 15 commits into from
Apr 26, 2020
Merged

Fixing some accessibility issues #1318

merged 15 commits into from
Apr 26, 2020

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Apr 24, 2020

  • Adding alt text to logo and gravatar
  • Adding (invisible) labels to dropdown buttons
  • Adding lang="en" to <html>
  • Adding aria-labels for inputs without label
  • Removing placeholders when they are identical to label
  • Adding tabindex to dialog to properly add tabbing behavior
  • Use bootstrap alert to display login errors

The remaining big accessibility thing would be contrast between font-color and background, but that would introduce very visible changes.

@campersau
Copy link
Collaborator

Chrome Accessibility Audit:

Before:
image

After:
image

@campersau campersau merged commit a71b81f into FredrikNoren:master Apr 26, 2020
@Hirse Hirse deleted the aria branch April 26, 2020 16:40
@campersau campersau mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants