Skip to content

Conversation

johscheuer
Copy link
Member

Description

Fixes: #2357

Type of change

  • New feature (non-breaking change which adds functionality)

Discussion

This is the first implementation approach to cleanup backups when the FoundationDBBackup resource is deleted and the according deletion policy is set (default is to keep everything running).

Testing

Ran an e2e test case with the policy.

Documentation

Updated the documentation.

Follow-up

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 776e628
  • Duration 1:58:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits but LGTM

@johscheuer johscheuer merged commit 3823e2a into FoundationDB:main Sep 10, 2025
8 of 9 checks passed
@johscheuer johscheuer deleted the add-finalizer-backup branch September 10, 2025 12:22
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: d61a01d
  • Duration 2:12:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: e6055a0
  • Duration 2:35:16
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup Isn't Cleaned Up on Backup Resource Deletion
3 participants