Update comments for backup finalizer changes

Author: johscheuer

controllers/backup_controller.go

@@ -249,7 +249,8 @@ func (r *FoundationDBBackupReconciler) updateOrApplySpec(
 	ctx context.Context,
 	backup *fdbv1beta2.FoundationDBBackup,
 ) error {
-	// For now just make use of the update method,during testing I observed some issues with the patch method.
+	// TODO(johscheuer): Implement the server-side apply feature, during testing we observed issues with the server-side
+	// apply.
 	return r.Update(ctx, backup)
 }
 

controllers/backup_controller_test.go

@@ -232,8 +232,7 @@ var _ = Describe("backup_controller", func() {
 		When("pausing a backup", func() {
 			BeforeEach(func() {
 				backup.Spec.BackupState = fdbv1beta2.BackupStatePaused
-				err = k8sClient.Update(context.TODO(), backup)
-				Expect(err).NotTo(HaveOccurred())
+				Expect(k8sClient.Update(context.TODO(), backup)).NotTo(HaveOccurred())
 			})
 
 			It("should pause the backup", func() {

docs/manual/backup.md

@@ -154,7 +154,8 @@ This can be changed by setting the `spec.deletionPolicy`, valid options are:
 
 When the `stop` or the `cleanup` deletion policy is set the operator will add the `foundationdb.org/fdb-kubernetes-operator` finalizer.
 It is not recommended to remove this finalizer manually, as this could lead to an incomplete removal of data.
-In the current implementation the delete step is implemented in the operator, this step might block one fo routine for a longer duration (up to 10 minutes before the reconciliation is retried).
+In the current implementation the delete step is implemented in the operator, this step might block for a longer duration (up to 10 minutes before the reconciliation is retried).
+If the operator is only started with a single go routine, this could also block other reconciliation attempts.
 
 Example for the `cleanup` policy: