Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon search #5163

Merged
merged 12 commits into from
Dec 9, 2014
Merged

Add icon search #5163

merged 12 commits into from
Dec 9, 2014

Conversation

williamboman
Copy link

Ping #4797.

@williamboman williamboman mentioned this pull request Dec 9, 2014
tagliala added a commit that referenced this pull request Dec 9, 2014
@tagliala tagliala merged commit a4f8218 into FortAwesome:4.3.0-wip Dec 9, 2014
@tagliala
Copy link
Member

tagliala commented Dec 9, 2014

@williamboman merged, thanks!

@williamboman
Copy link
Author

Nice! Any ETA on 4.3 release?

Den 9 dec 2014 13:46 skrev "Geremia Taglialatela" <notifications@github.com
:

@williamboman https://github.com/williamboman merged, thanks!


Reply to this email directly or view it on GitHub
#5163 (comment)
.

@tagliala
Copy link
Member

tagliala commented Dec 9, 2014

@williamboman : sorry, I think I can't disclose this information...

please take "soon" as an answer

tagliala added a commit that referenced this pull request Dec 9, 2014
@tagliala
Copy link
Member

tagliala commented Dec 9, 2014

This PR contained a breaking change and I didn't notice.

You should not have removed aliases for picture-o.

Added back via d16433c

@williamboman
Copy link
Author

Oops, didn't notice that either. I think it came from @gkoberger's commits from last year.

@tagliala
Copy link
Member

tagliala commented Dec 9, 2014

no problem 👍

@tagliala
Copy link
Member

tagliala commented Dec 9, 2014

@williamboman we have another issue

Chrome 39, OSX 10.10.1

  1. Search for photo (or whatever produces results)
  2. Click on "x"

image

edit: same on safari, firefox

edit2: doesn't happen with CMD+A + backspace

@williamboman
Copy link
Author

Hmm.. I'll take a look at this and PR a fix.

Den 9 dec 2014 16:47 skrev "Geremia Taglialatela" <notifications@github.com
:

@williamboman https://github.com/williamboman we have another issue

Chrome 39, OSX 10.10.1

  1. Search for photo (or whatever produces results)
  2. Click on "x"

[image: image]
https://cloud.githubusercontent.com/assets/556268/5360161/d6fdd08c-7fc2-11e4-9836-74c796ae539f.png


Reply to this email directly or view it on GitHub
#5163 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants