Skip to content

Commit

Permalink
removed breaking change
Browse files Browse the repository at this point in the history 
refers to #5163
  • Loading branch information
@tagliala
tagliala committed Dec 9, 2014
1 parent a4f8218 commit d16433c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Loading

5 comments on commit d16433c

@tagliala
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not having aliases would break css.

try to regenerate and take a look

@tagliala
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got it.

@williamboman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just wanted to point out that the filter array is redundant in this case as it's basically an extension to the aliases array, but exclusively used when searching.

@tagliala
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, got it a little bit late

you mean this, right? b85ea4b

@williamboman
Copy link

@williamboman williamboman commented on d16433c Dec 9, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.