Kara/print and export #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Default printTheme to overwrite the colors for a more suitable printing experience (needs to be changed later) 1. Add logic to src/theme/index.js to check whether there is a print query and if so apply the printTheme to the mergedTheme. 1. Add logic to slide to remove background color and change it to white for printing when print query.
1. Added exportMode to useDeck. 1. Changed layout of slides depending on `?exportMode=true` using print-deck. 1. Added @print media query to fullscreen and progress components.
kiraarghy
force-pushed
the
kara/printAndExport
branch
from
2f50eeb to
422135b
Compare
src/components/slide.js
Outdated
| : { | ||
| transform: `scale(${ratio})`, | ||
| transformOrigin: `${origin.x} ${origin.y}` | ||
| } |
There was a problem hiding this comment.
This is starting to get a little big, perhaps time to move to a React.useMemo?
src/components/slide.js
Outdated
| transformOrigin: `${origin.x} ${origin.y}` | ||
| }} | ||
| backgroundColor={ | ||
| window.location.search.includes('print') ? '#ffffff' : backgroundColor |
There was a problem hiding this comment.
Could we get this from the useUrlRouting hook?
There was a problem hiding this comment.
Missed this, will get this done!
ryan-roemer
reviewed
Oct 31, 2019
| return merged; | ||
| }, deepCopy(defaultTheme)); | ||
|
|
||
| export const mergeTheme = theme => { |
There was a problem hiding this comment.
@kiraarghy and I slack chatted a minor refactor here.
ryan-roemer
approved these changes
Oct 31, 2019
Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket implements the export and print functionality that was in original Spectacle.
When a user uses the
exportModeflag, when they print it will output each slide as a single page.When a user uses the
printModeflag, it will apply a print theme and a white background, saving on printing.The printTheme has alright contrast at the moment, though am more than happy to take input on it @alex-saunders you're pretty good at this kinda thing.
I have also added a lightTheme for the codepane when in
printMode.