Code Pane! #712
Merged
Code Pane! #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # src/components/deck.js
carloskelly13
commented
Aug 28, 2019
| import TestMDX from './examples/mdx/test-mdx'; | ||
| // import TestJs from './examples/JS/TestJS.js'; | ||
| // import TestMDX from './examples/mdx/test-mdx'; | ||
| import TestJs from './examples/js/test-js'; |
There was a problem hiding this comment.
This fixes a filename case issue.
carloskelly13
commented
Aug 28, 2019
| }, [navigateToCurrentUrl]); | ||
|
|
||
| React.useLayoutEffect(() => { | ||
| document.body.style.margin = '0'; |
There was a problem hiding this comment.
Some browsers add extra margins to body which throws off the full size slides. Ordinarily in an app we'd use a CSS reset, but we don't want our users to have to fuss with loading a CSS file and JS.
carloskelly13
commented
Aug 28, 2019
| right: 0, | ||
| position: 'absolute' | ||
| }), | ||
| [] |
There was a problem hiding this comment.
This is just a memoized base style. Likely when we land upon a theming solution this would get refactored into that.
carloskelly13
requested review from
SunburtReynolds,
kale-stew and
rgerstenberger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
<CodePane />component to Spectacle rewrite!prism-react-rendererat the coreOther improvements
Animated Example of 2 code slides each with their own font!
