Skip to content

Conversation

@sodoku
Copy link
Contributor

@sodoku sodoku commented Mar 4, 2018

Got a quite cryptic error:

Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined.
You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of `Heading`.

Took me a while to realize, that I tried to use a Heading with size 7. The proposed error is more obvious to me.

@ryan-roemer
Copy link
Member

Hi @sodoku -- Thanks for the PR. Currently this is failing CI -- can you read through our PR submission guidelines + practices to get this PR in shape? https://github.com/FormidableLabs/spectacle/blob/master/CONTRIBUTING.md#before-submitting-a-pr

Thanks!

@sodoku
Copy link
Contributor Author

sodoku commented Mar 5, 2018

@ryan-roemer thanks for telling me so nicely and sorry for wasting extra time. I committed a fix.

@ghost ghost merged commit fb2ff81 into FormidableLabs:master Apr 30, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants