Merge pull request #481 from sodoku/patch-1

Stan Zhao · web-flow · commit fb2ff817e63f · 2018-04-30T13:50:46.000-07:00
Throw error if heading size is higher than 6
diff --git a/src/components/heading.js b/src/components/heading.js
@@ -88,6 +88,9 @@ export default class Heading extends Component {
   }
   render() {
     const { size, lineHeight, fit, style, children } = this.props;
+    if (size > 6) {
+      throw new Error('Heading size must be between 1 and 6');
+    }
     const Tag = `h${size}`;
     const typefaceStyle = this.context.typeface || {};
 

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,9 @@ export default class Heading extends Component {`
`88`	`88`	`}`
`89`	`89`	`render() {`
`90`	`90`	`const { size, lineHeight, fit, style, children } = this.props;`
	`91`	`+ if (size > 6) {`
	`92`	`+ throw new Error('Heading size must be between 1 and 6');`
	`93`	`+ }`
`91`	`94`	const Tag = `h${size}`;
`92`	`95`	`const typefaceStyle = this.context.typeface \|\| {};`
`93`	`96`