Skip to content
This repository was archived by the owner on Feb 19, 2022. It is now read-only.

temporarily fix the mdx syntax highlight bug #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

temporarily fix the mdx syntax highlight bug #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions presentation/components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@ const _CombineBlockQuote = ({ children }) => (

_CombineBlockQuote.propTypes = { children: PropTypes.node };

const _CodePane = ({ children, language }) => (
<CodePane theme="external" lang="javascript" source={children} />
);
// Do not change this component if you want proper syntax highlighting in MDX
const _CodePane = ({ children, className }) => {
const language = className.replace(/language-/, '')
return <CodePane theme="external" lang={language} source={children} />
};

_CodePane.propTypes = { code: PropTypes.string, language: PropTypes.string };

Expand Down
26 changes: 18 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1944,9 +1944,10 @@ create-hmac@^1.1.0, create-hmac@^1.1.2, create-hmac@^1.1.4:
safe-buffer "^5.0.1"
sha.js "^2.4.8"

create-react-context@^0.2.2:
create-react-context@^0.2.2, create-react-context@^0.2.3:
version "0.2.3"
resolved "https://registry.yarnpkg.com/create-react-context/-/create-react-context-0.2.3.tgz#9ec140a6914a22ef04b8b09b7771de89567cb6f3"
integrity sha512-CQBmD0+QGgTaxDL3OX1IDXYqjkp2It4RIbcb99jS6AEg27Ga+a9G3JtK6SIu0HBwPLZlmwt9F7UwWA4Bn92Rag==
dependencies:
fbjs "^0.8.0"
gud "^1.0.0"
Expand Down Expand Up @@ -2027,6 +2028,11 @@ cssesc@^0.1.0:
version "0.1.0"
resolved "https://registry.yarnpkg.com/cssesc/-/cssesc-0.1.0.tgz#c814903e45623371a0477b40109aaafbeeaddbb4"

csstype@^2.6.0:
version "2.6.3"
resolved "https://registry.yarnpkg.com/csstype/-/csstype-2.6.3.tgz#b701e5968245bf9b08d54ac83d00b624e622a9fa"
integrity sha512-rINUZXOkcBmoHWEyu7JdHu5JMzkGRoMX4ov9830WNgxf5UYxcBUO0QTKAqeJ5EZfSdlrcJYkC8WwfVW7JYi4yg==

currently-unhandled@^0.4.1:
version "0.4.1"
resolved "https://registry.yarnpkg.com/currently-unhandled/-/currently-unhandled-0.4.1.tgz#988df33feab191ef799a61369dd76c17adf957ea"
Expand Down Expand Up @@ -5194,12 +5200,14 @@ react-lifecycles-compat@^3.0.4:
version "3.0.4"
resolved "https://registry.yarnpkg.com/react-lifecycles-compat/-/react-lifecycles-compat-3.0.4.tgz#4f1a273afdfc8f3488a8c516bfda78f872352362"

react-live@^1.11.0:
version "1.11.0"
resolved "https://registry.yarnpkg.com/react-live/-/react-live-1.11.0.tgz#257b54abb64df250bc40b0572c21acd600ecdd5c"
react-live@^1.12.0:
version "1.12.0"
resolved "https://registry.yarnpkg.com/react-live/-/react-live-1.12.0.tgz#2876d4e913331002b66dfa73cf58051376bc2518"
integrity sha512-zFEpY01fJORF0IiyONqvjwPLBBDp155Ive6tU8ZmetmT2p4XWUKHstnlu4Cayia+n7iu58Owytztu43yvSin8g==
dependencies:
buble "^0.19.3"
core-js "^2.4.1"
create-react-context "^0.2.3"
dom-iterator "^1.0.0"
prismjs "1.6"
prop-types "^15.5.8"
Expand Down Expand Up @@ -5908,10 +5916,12 @@ spectacle-renderer@^0.0.3:
puppeteer "^0.12.0"
yargs "^9.0.1"

spectacle@5.2.2:
version "5.2.2"
resolved "https://registry.yarnpkg.com/spectacle/-/spectacle-5.2.2.tgz#b5e717c85db47fe5dd267ff6562b9463b24fc1bc"
spectacle@5.4.0:
version "5.4.0"
resolved "https://registry.yarnpkg.com/spectacle/-/spectacle-5.4.0.tgz#01f7aab5d4fb54bde82066be0fbbb87fe6737fcc"
integrity sha512-cazr4CZkTdb7FXAoLkPvTYDam1wwzw5s8O72lREO3HiGYK8Eg7wrg4vy+w9et401XXQWEcRzQOmEp91sWIjPJQ==
dependencies:
csstype "^2.6.0"
deep-object-diff "^1.0.4"
emotion "^8.0.8"
history "^4.6.1"
Expand All @@ -5920,7 +5930,7 @@ spectacle@5.2.2:
normalize.css "^7.0.0"
prismjs "1.6.0"
react-emotion "^8.0.8"
react-live "^1.11.0"
react-live "^1.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Wendy! This all looks great, but I am going to make a small change and revert to the previous version of react-live - there's a weird issue where the version always has to be the same as whatever prismjs is using, so I want to keep that aligned. Once I've made that change I'll merge it - just wanted to give you the context there!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, thanks!

react-redux "^5.0.5"
react-transition-group "1.2.1"
react-typography "^0.16.5"
Expand Down