This repository was archived by the owner on Feb 19, 2022. It is now read-only.
temporarily fix the mdx syntax highlight bug #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsparsons
changed the title
ebrillhart
reviewed
Apr 1, 2019
| prismjs "1.6.0" | ||
| react-emotion "^8.0.8" | ||
| react-live "^1.11.0" | ||
| react-live "^1.12.0" |
There was a problem hiding this comment.
Hey Wendy! This all looks great, but I am going to make a small change and revert to the previous version of react-live - there's a weird issue where the version always has to be the same as whatever prismjs is using, so I want to keep that aligned. Once I've made that change I'll merge it - just wanted to give you the context there!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
languageas a prop, need to passclassNameand use regex set the language as a variable