Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Upgrade lambda node version from 8 to 12 #60

Merged
merged 3 commits into from
Dec 31, 2019
Merged

Upgrade lambda node version from 8 to 12 #60

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
635659d
Upgrade lambda node version from 8 to 12
stevenmusumeche Dec 30, 2019
90cb100
set min node version to 10
stevenmusumeche Dec 31, 2019
966413d
remove engines config from package.json
stevenmusumeche Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.10
12.14.0
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"repository": "https://github.com/FormidableLabs/aws-lambda-serverless-reference",
"author": "Ryan Roemer <ryan.roemer@formidable.com>",
"license": "MIT",
"engines": {
"node": ">=10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(picking up on actual visible code thread) My vote here is remove the engines until we use something that is actually node10+ and use .nvmrc as our best practice means of getting folks on the right engine. AWS will still support create + update node8 for a few more months and nothing has changed in our very node8 friendly code...

... but I'm not going to block on this if you have consensus from the backend devs team and feel it's a move we should take here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, i'll remove it

},
"scripts": {
"postinstall": "cd layers/vendor/nodejs && yarn",
"_dev:on": "sed -i '' 's/FormidableLabs\\/serverless\\/aws/\\.\\.\\/\\.\\.\\/terraform-aws-serverless/g' terraform/main.tf",
Expand Down
2 changes: 1 addition & 1 deletion serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ provider:
# Fn::ImportValue: tf-${self:custom.service}-${self:custom.stage}-LambdaExecutionRoleCustomArn

# Lambda configuration
runtime: nodejs8.10
runtime: nodejs12.x
timeout: 30 # seconds (`300` max)
memorySize: 128 # MB value (`1024` default)

Expand Down