This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Upgrade lambda node version from 8 to 12 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
reviewed
Dec 30, 2019
ryan-roemer
reviewed
Dec 30, 2019
service: sls-simple-reference
stage: sandbox
region: us-east-1
stack: sls-simple-reference-sandbox
resources: 50
api keys:
None
endpoints:
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/base
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/base/{proxy+}
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/xray
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/xray/{proxy+}
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/vpc
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/vpc/{proxy+}
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/canary
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/canary/{proxy+}
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/layers
ANY - https://amx4dqzs4j.execute-api.us-east-1.amazonaws.com/sandbox/layers/{proxy+}
functions:
base: sls-simple-reference-sandbox-base
xray: sls-simple-reference-sandbox-xray
vpc: sls-simple-reference-sandbox-vpc
canary: sls-simple-reference-sandbox-canary
layers: sls-simple-reference-sandbox-layers
layers:
vendor: arn:aws:lambda:us-east-1:819013376994:layer:sls-simple-reference-sandbox-vendor:41
repeat: arn:aws:lambda:us-east-1:819013376994:layer:sls-simple-reference-sandbox-repeat:44 |
ryan-roemer
reviewed
Dec 31, 2019
package.json
Outdated
| @@ -5,6 +5,9 @@ | |||
| "repository": "https://github.com/FormidableLabs/aws-lambda-serverless-reference", | |||
| "author": "Ryan Roemer <ryan.roemer@formidable.com>", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": ">=10" | |||
There was a problem hiding this comment.
(picking up on actual visible code thread) My vote here is remove the engines until we use something that is actually node10+ and use .nvmrc as our best practice means of getting folks on the right engine. AWS will still support create + update node8 for a few more months and nothing has changed in our very node8 friendly code...
... but I'm not going to block on this if you have consensus from the backend devs team and feel it's a move we should take here.
There was a problem hiding this comment.
sounds good, i'll remove it
ryan-roemer
approved these changes
Dec 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32