Add logistic regression example on iris dataset. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeInnes
reviewed
Mar 7, 2019
other/iris/iris.jl
Outdated
|
|
||
|
|
||
| # Start Training. | ||
| for epoch in 1:100 |
There was a problem hiding this comment.
This could be done with something like data = Iterators.repeat((X, Y), 100).
JoshuaWhittemore
force-pushed
the
add-iris-logistic-regression
branch
from
bdba607
to
0591270
Compare
|
Hi Mike, I've changed the call to One thing - this model depends on FluxML/Flux.jl#652 for its dataset. Thank you! |
|
That PR is merged, so presumably this just needs the manifest to be updated? |
|
Yes I think so. I was going to do that today. I just need to figure out how to require that it use Flux 0.8.1+ I think. |
|
Err, 0.8.1 or 0.8.1+ I guess. |
JoshuaWhittemore
force-pushed
the
add-iris-logistic-regression
branch
from
0591270
to
de0df39
Compare
add julia prompt to REPL excerpt in README.md
|
I've updated the manifest. Let me know if there's anything else I should do. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super simple model aimed at helping beginners get started with Flux.
It depends on an 'iris' Data module in Flux, PR here: FluxML/Flux.jl#652.
If it doesn't make sense to have the iris Data module in Flux I can move that over here.
Please make any suggestions/changes you think might be appropriate. Thank you!