Add module to make iris dataset available. #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. Can you add a test, and also a NEWS.md entry? |
JoshuaWhittemore
force-pushed
the
add-module-to-download-iris-dataset
branch
from
b774a27
to
930ebaf
Compare
|
Thanks Mike. I've added the tests and an entry to NEWS.md. Let me know if you have any other thoughts. |
|
👍 Thanks! |
BerenMillidge
pushed a commit
to BerenMillidge/Flux.jl
that referenced
this pull request
Dec 20, 2019
BerenMillidge
pushed a commit
to BerenMillidge/Flux.jl
that referenced
this pull request
Dec 20, 2019
…wnload-iris-dataset Add module to make iris dataset available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple module for downloading and preparing the Iris dataset from the UCI ML repo.
I have no idea if this kind of module is the sort of thing that belongs in Flux or not. I should have opened an issue for this first before coding it.
If it is appropriate for Flux but needs work, please make any suggestions/changes that you think make sense. Thank you!