Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part fix イタチの大暴発 #1785

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

mercury233
Copy link
Collaborator

If one monster's ATK is above 0xFFFF(65535), MSG_SELECT_SUM won't work because opParam has the max of 0xFFFFFFFF and will be splited.

@mercury233 mercury233 marked this pull request as draft January 1, 2022 13:58
@salix5
Copy link
Collaborator

salix5 commented Jan 3, 2022

Maybe we should modify MSG_SELECT_SUM, PROCESSOR_SELECT_SUM.
acc should be treated as int32.

@salix5
Copy link
Collaborator

salix5 commented Mar 3, 2022

@mercury233
https://github.com/Fluorohydride/ygopro-core/blob/169d577bc8cfd133b54c9d829b540626245537ac/playerop.cpp#L632

pduel->write_buffer32(acc & 0xffff);

Why do we use bitwise and here?

@mercury233
Copy link
Collaborator Author

the other operation params can't get beyond 0xffff

@purerosefallen
Copy link
Collaborator

How about, lower the precision of attack count for 1/10.
Like, we may treat atk 1000 as value 100, and treat LP 8000 as LP 800. In this way number would be much smaller that monster with atk 655350 could fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants