Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refuse Group.SelectWithSumEqual with more than 127 max #473

Merged

Conversation

mercury233
Copy link
Collaborator

If max go beyond 127, arg2 here will exceed int32.

pduel->game_field->add_process(PROCESSOR_SELECT_SUM, 0, 0, 0, acc, playerid + (min << 16) + (max << 24));

But, we still can't select among all cards in a group bigger than 127: #449
And, Group.SelectWithSum... are not safe for values bigger than 65535: Fluorohydride/ygopro-scripts#1785

BTW, it is the only problem I found in #451

@mercury233 mercury233 merged commit 26696ce into Fluorohydride:master Sep 28, 2022
@mercury233 mercury233 deleted the patch-selectsum-overflow branch September 28, 2022 00:44
realSetoKaiba pushed a commit to Kaiba-Corporation/ygopro-core that referenced this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant