refuse Group.SelectWithSumEqual with more than 127 max #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
max
go beyond 127,arg2
here will exceed int32.ygopro-core/libgroup.cpp
Line 461 in 11772de
But, we still can't select among all cards in a group bigger than 127: #449
And,
Group.SelectWithSum...
are not safe for values bigger than 65535: Fluorohydride/ygopro-scripts#1785BTW, it is the only problem I found in #451