-
Notifications
You must be signed in to change notification settings - Fork 6
Add more linux packaging #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need these libs in the FHS Shell so Nix users can actually build the linux packages needed.
This sets up debian and tarball packaging, adds project maintainers and contact info (please consider them placeholders!), and add new targets for linux packaging. We unfortunately MUST put down an author with an email, so I'm putting myself down. That being said, I'd really like this to change.
|
Looks good, I don't have any experience with packaging, I usually just compile common binaries. But I can actively test the Debian package because I currently use a Debian-based distro, so I can help with that, testing the package. |
|
As part of the team and an active Debian user, I suppose I should be responsible for testing that the .deb package is fine and works, not necessarily meaning that I should be the maintainer or author in the description, but at least testing and making sure that it always works correctly n.n So count me in whenever you want to know if the Debian package is working properly and so on. |
nubesurrealista
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question. I would like to maintain compatibility with Debian 12, since, well, I'm still there. Debian 12 still has another year of support, so I don't think it should be abandoned when distributing software.
I mean, because the workflow uses Ubuntu latest, the binaries compiled in Ubuntu latest are not compatible with the glibc version of Debian 12, which would mean that any user on Debian 12 or based distros would not be able to use our software. Although I don't know if that's the case here, my personal workflow compiles an appimage on Ubuntu latest and I can use it, so I don't know if that principle applies here.
|
It's ready to test right now! Would love it if you try. It should work with Debian 12, I would expect, but if not, we should use a debian builder. That can be added if it doesn't work. Have you built a deb package yet with |
|
Also for the record, this does not yet handle releases. That's done in #83. |
nubesurrealista
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I can confirm that building on ubuntu latest is not a problem for debian 12, the package is compatible. Sorry for the confusion haha, there is software that doesn't work in debian 12 when you compile it in ubuntu latest and I thought it was the general rule
|
Awesome! That's great to hear. I would be surprised if it didn't work as Electron/Chromium I think ships with many of its own libc functions, and we don't build Electron when we run |
This adds:
i. debian
ii. tarball
Note that because we're now packaging a .deb, we MUST provide an author with a contact email address. I've put my own down for now, as I'm the most consistent contributor for maintenance, but I'd ideally have it not be me.