Skip to content

Conversation

@hardillb
Copy link
Contributor

fixes #6232

Description

Allows scheduling to restart Node-RED and not apply updates

image

Default is to do stack update, but can be changed to just restart on same schedule.

Related Issue(s)

#6232

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from cstns December 12, 2025 11:31
@hardillb hardillb self-assigned this Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.30%. Comparing base (687c618) to head (d17b872).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...rge/ee/lib/autoUpdateStacks/tasks/upgrade-stack.js 0.00% 13 Missing ⚠️
forge/ee/routes/autoUpdateStacks/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6408   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files         395      395           
  Lines       19821    19821           
  Branches     4747     4747           
=======================================
  Hits        15124    15124           
  Misses       4697     4697           
Flag Coverage Δ
backend 76.30% <6.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knolleary
Copy link
Member

The options appear to be mutually exclusive; does this mean a user can't have both regular restarts and automatic upgrades? It feels like it should be possible to enable both?

@hardillb
Copy link
Contributor Author

@knolleary this was a deliberate choice, let me see if I can find it in the original isssue

@hardillb
Copy link
Contributor Author

hardillb commented Dec 16, 2025

@knolleary I can't find it, but I'm sure it was discussed, I think with regard to the original upgrade PR as that is when the backend was done for just restarting.

I can look at changing it if needed?

@knolleary
Copy link
Member

@hardillb it feels like it should be possible to enable both.

 - [ ] Apply updates when available
 - [ ] Restart Node-RED even if no update is available

@hardillb
Copy link
Contributor Author

@knolleary pushed updates

@knolleary knolleary merged commit 0ba1917 into main Dec 18, 2025
27 checks passed
@knolleary knolleary deleted the scheduled-instance-restarts branch December 18, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule instance restart without NR update

4 participants