Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bring to focus functionality #585

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Added bring to focus functionality #585

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35aced9
Added bring to focus functionality
Jan 14, 2021
bef2b97
Added return type for bring to focus
Jan 15, 2021
58965dd
Added doc for bringToFocus
Jan 21, 2021
f363ec0
Fixed tslint issue
Jan 21, 2021
f2307f2
Merge branch 'master' into bring-to-focus
naqvitalha Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/core/RecyclerListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,28 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
}
}

public bringToFocus(index: number, animate?: boolean): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anirudhagarwal365 can you also add documentation around this in readme and as a comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @naqvitalha

const listSize = this.getRenderedSize();
const itemLayout = this.getLayout(index);
const currentScrollOffset = this.getCurrentScrollOffset();
const {isHorizontal} = this.props;
if (itemLayout) {
const mainAxisLayoutDimen = isHorizontal ? itemLayout.width : itemLayout.height;
const mainAxisLayoutPos = isHorizontal ? itemLayout.x : itemLayout.y;
const mainAxisListDimen = isHorizontal ? listSize.width : listSize.height;
const screenEndPos = mainAxisListDimen + currentScrollOffset;
if (mainAxisLayoutDimen > mainAxisListDimen || mainAxisLayoutPos < currentScrollOffset || mainAxisLayoutPos > screenEndPos) {
this.scrollToIndex(index);
} else {
const viewEndPos = mainAxisLayoutPos + mainAxisLayoutDimen;
if (viewEndPos > screenEndPos) {
const offset = viewEndPos - screenEndPos;
this.scrollToOffset(0, offset + currentScrollOffset, animate);
}
}
}
}

public scrollToItem(data: any, animate?: boolean): void {
const count = this.props.dataProvider.getSize();
for (let i = 0; i < count; i++) {
Expand Down