Added bring to focus functionality #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
reviewed
Jan 21, 2021
| @@ -242,6 +242,28 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends | |||
| } | |||
| } | |||
|
|
|||
| public bringToFocus(index: number, animate?: boolean): void { | |||
There was a problem hiding this comment.
@anirudhagarwal365 can you also add documentation around this in readme and as a comment?
There was a problem hiding this comment.
Sure @naqvitalha
added 2 commits
January 21, 2021 18:41
naqvitalha
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to bring to focus a particular index. This API is almost similar to scrollToIndex, but differs when the view is already in viewport. Instead of bringing the view to the top of the viewport, it will calculate the overflow the the selected index and scroll to just bring the entire view to viewport.