Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the initial empty render of the scrollview if a scrollviewsize is passed #450

Merged
merged 18 commits into from
May 4, 2020
Merged

Remove the initial empty render of the scrollview if a scrollviewsize is passed #450

Changes from 4 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
853dfef
Adding a layout size prop to take initial size of RLV and use this re…
arunreddy10 Nov 28, 2019
f7fabc5
Removing visibility related changes
arunreddy10 Nov 29, 2019
7e280a6
Moving componentDidMount logic into constructor
arunreddy10 Nov 29, 2019
a79a31b
Renaming layoutSize to scrollViewSize prop
arunreddy10 Jan 7, 2020
d21756a
Rebasing from master
arunreddy10 Jan 9, 2020
7e6fea2
Merge branch 'master' into removeInitialEmptyRender
naqvitalha Feb 5, 2020
d179356
Fixing initial offset
naqvitalha Feb 5, 2020
448a740
Merge branch 'master' into removeInitialEmptyRender
naqvitalha Feb 5, 2020
eb4e896
Handling the case when initial offset is provided and preventing forc…
arunreddy10 Feb 23, 2020
4f3f850
Version bump
arunreddy10 Feb 23, 2020
ce8ac5f
Version bump to beta before publishing
arunreddy10 Feb 27, 2020
f9d4506
Moved willMountCompat logic to constructor and removed acceptableLayo…
arunreddy10 Apr 24, 2020
de78f3b
Undo acceptable relayout delta changes
arunreddy10 Apr 24, 2020
4246b45
Renaming getContextFromProvider method
arunreddy10 Apr 24, 2020
809c244
version bump
arunreddy10 May 1, 2020
90ed7e3
fix: removed extra changes
arunreddy10 May 1, 2020
7bf8055
Renaming prop to scrollViewSize and using cachedLayouts in forceRende…
arunreddy10 May 2, 2020
8f093bc
Renaming prop to layoutSize and moving forceFullRender to separate block
arunreddy10 May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions src/core/RecyclerListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export interface RecyclerListViewProps {
onVisibleIndicesChanged?: TOnItemStatusChanged;
renderFooter?: () => JSX.Element | JSX.Element[] | null;
externalScrollView?: { new(props: ScrollViewDefaultProps): BaseScrollView };
scrollViewSize?: Dimension;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call out edge cases

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in readme

initialOffset?: number;
initialRenderIndex?: number;
scrollThrottle?: number;
Expand Down Expand Up @@ -152,6 +153,8 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
private _scrollComponent: BaseScrollComponent | null = null;

private _defaultItemAnimator: ItemAnimator = new DefaultItemAnimator();
private _isSizeChangedCalledOnce: boolean = false;
private _hasMounted: boolean = false;

constructor(props: P, context?: any) {
super(props, context);
Expand All @@ -161,10 +164,18 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
return this.props.dataProvider.getStableId(index);
}, !props.disableRecycling);

this.state = {
internalSnapshot: {},
renderStack: {},
} as S;
if (props.scrollViewSize) {
this._layout.height = props.scrollViewSize.height;
this._layout.width = props.scrollViewSize.width;
this._initComplete = true;
this._initTrackers();
this._processOnEndReached();
} else {
this.state = {
internalSnapshot: {},
renderStack: {},
} as S;
}
}

public componentWillReceivePropsCompat(newProps: RecyclerListViewProps): void {
Expand Down Expand Up @@ -201,6 +212,10 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
}
}

public componentDidMount(): void {
this._hasMounted = true;
}

public componentWillUnmount(): void {
if (this.props.contextProvider) {
const uniqueKey = this.props.contextProvider.getUniqueKey();
Expand Down Expand Up @@ -440,17 +455,28 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
if ((hasHeightChanged && hasWidthChanged) ||
(hasHeightChanged && this.props.isHorizontal) ||
(hasWidthChanged && !this.props.isHorizontal)) {
this._checkAndChangeLayouts(this.props, true);
const forceFullRender = this._isSizeChangedCalledOnce ? true : false;
this._checkAndChangeLayouts(this.props, forceFullRender);
} else {
this._refreshViewability();
}
}
if (!this._isSizeChangedCalledOnce) {
this._isSizeChangedCalledOnce = true;
}
}

private _renderStackWhenReady = (stack: RenderStack): void => {
this.setState(() => {
return { renderStack: stack };
});
if (!this._hasMounted) {
this.state = {
internalSnapshot: {},
renderStack: stack,
} as S;
} else {
this.setState(() => {
return { renderStack: stack };
});
}
}

private _initTrackers(): void {
Expand Down