Remove the initial empty render of the scrollview if a scrollviewsize is passed #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder to remove initial shift by making opacity 0
naqvitalha
reviewed
Jan 7, 2020
src/core/RecyclerListView.tsx
Outdated
| @@ -91,6 +91,7 @@ export interface RecyclerListViewProps { | |||
| onVisibleIndicesChanged?: TOnItemStatusChanged; | |||
| renderFooter?: () => JSX.Element | JSX.Element[] | null; | |||
| externalScrollView?: { new(props: ScrollViewDefaultProps): BaseScrollView }; | |||
| scrollViewSize?: Dimension; | |||
There was a problem hiding this comment.
Added in readme
…e render when the onLayout is called for the first time
|
Please i need this, its posible merge? |
|
@arunreddy10 thanks, working perfectly :), now its full replacement for flatlist and sectionList |
…utDelta check from gridlayoutmanager
naqvitalha
requested changes
May 3, 2020
src/core/RecyclerListView.tsx
Outdated
| @@ -675,6 +717,11 @@ RecyclerListView.propTypes = { | |||
| //Specify the initial item index you want rendering to start from. Preferred over initialOffset if both are specified. | |||
| initialRenderIndex: PropTypes.number, | |||
|
|
|||
| //Specify the estimated size of the recyclerlistview to render the list items in the first pass. If not provided, the recyclerlistview | |||
| //will first render with no items and then fill in the items based on the size given by its onLayout event. When provided, the items are | |||
| //rendered in the first pass according to the estimated size and then adjusted according to the actual size when the onLayout event arrives. | |||
There was a problem hiding this comment.
This isn't true right? With the new changes?
There was a problem hiding this comment.
Updated the comments.
README.md
Outdated
| @@ -107,6 +107,7 @@ not be as fast. | |||
| | optimizeForInsertDeleteAnimations | No | boolean | Enables you to utilize layout animations better by unmounting removed items | | |||
| | style | No | object | To pass down style to inner ScrollView | | |||
| | scrollViewProps | No | object | For all props that need to be proxied to inner/external scrollview. Put them in an object and they'll be spread and passed down. | | |||
| | scrollViewSize | No | Dimension | Will prevent the initial empty render required to compute the size of the listview and use these dimensions to render list items in the first render itself. This is useful for cases such as server side rendering. | | |||
There was a problem hiding this comment.
Mention how canChangeSize can help
There was a problem hiding this comment.
Added a comment for the same
src/core/RecyclerListView.tsx
Outdated
| @@ -391,7 +410,15 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends | |||
| } | |||
| if (forceFullRender || this.props.layoutProvider !== newProps.layoutProvider || this.props.isHorizontal !== newProps.isHorizontal) { | |||
| //TODO:Talha use old layout manager | |||
| this._virtualRenderer.setLayoutManager(newProps.layoutProvider.newLayoutManager(this._layout, newProps.isHorizontal)); | |||
| if (forceFullRender) { | |||
There was a problem hiding this comment.
This isn't what we want
There was a problem hiding this comment.
If layoutProvider and orientation changes we do the old thing. If only forceFullRender we use cached layouts.
There was a problem hiding this comment.
Moved forceFullRender to separate if condition
naqvitalha
approved these changes
May 4, 2020
|
hi @naqvitalha , @arunreddy10 Why not merge request ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior of recyclerlistview is to render an empty scrollview and then wait for its on layout event to get its actual size before rendering all the children inside it. If an estimated scroll view size is passed, then the children can also be rendered in the first pass based on those estimates removing an initial blank render. To change the size after render, canChangeSize must be set to true.