End reached margin fix #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Sticky Container init. * Sticking view on scroll. * Using view from row renderer. * topStickyIndices done/ * Top and bottom stickies separated. * Sticky header cascading and recycler react clone element * Header cascading. * Using StickyObject. * Using Sticky Header. * Sticky Footer used without multiplier. * Sticky type context. * Footer cascading working. Header and footer logic to be merged. * Using Scroll component height. * Previous sticky indice logic combined for header and footer. * Next sticky index logic combined for header and footer. * Sticky multiplier abstracted. * Initial visibility abstracted and naming conventions. * Container position. * Refactoring. * Getting rid of tentative sliding. * Cleaning StickyContainer. * Removed rerender. * Computing layouts on indices change. * Layout specifics abstracted. * Init params and redundant methods removed. * Using hashmap for visible indices. * onVisibleIndexesChanged refactored. * Calling super visible indices changed. * Commented on receive props lines, modified todos. * Todos. * Recycler ref passed in visible indices changed and footer visibility dynamic. * Deprecated visible indexes changed. * Initial visibility bug fix. * Resolved recylerRef any. * Sending data in rowRenderer. * Refactoring private vars. * Fixes and refactoring. * Resolved ref proxy. * Scroll to handled for headers. * Sticky Container prop types. * Header scroll to todo removed and footer initial visibility bug fix. * Indice to index... * Sticky footer on load. * Reverting type ScrollComponent. * Refactoring. * Custom recycler react element type. * Correct child type asserted. * Moved compute layouts to on scroll. * Bug fixes. * Compute layout bug fix. * Resetting sticky view offset value bug fix. * Bumped version. * Made props optional. * Added overrideRowRenderer and passing sticky layout type. * Added overrideRowRenderer and passing sticky layout type. * Override row renderer functional. * rowRenderer type fix. * Ts fix. * Bumped sticky version. * Sticky indices made function. * Added compute layouts in visible indices changed. * Bumped version. * Reverting to array sticky params. * Visible indices logic changed. * Default offset 0. * Removed maintaining visible indices. * Renamed method. * Renamed initial visibility. * Made compute layouts public. * Compute layouts again made private. * Setting state after refs are obtained. * Keeping init indices and calling after ref init. * Bumping version. * Removing unnecessary semicolons. * Passing extended state in rowRenderer. * Refactor. * CR changes. * CR changes. * CR changes. * Removing compute layouts from on scroll. * Using all as sorted array. * RLV dims and ficker bug fixes. * Pagination sticky removal bug fix. * Bumped sticky version. * Bumping version. * Refactor. * Build fixes and version bump. * Adding style prop to container. * Sorting indices. * Not passing recyclerRef to Sticky object. * Bumping version. * Removed refs and undefined params. * Bumped version. * Edited doc. * Binary search to find smallest index. * Footer binary search added, refactoring, error handling. * Bug fix. * Removed unused method. * Readme init. * Doc, defs and sort removal. * Sticky docs. * Handling onBoundaryReached cases. * Bumped version. * Solved for sticky header initial. * Boundary processing abstracted and footer solved. * Bumped version. * OnEndReached bug fix. * Added onVisibleEndReached and using it instead of onEndReached. * Flooring windowBound - offset. (#297) * Boundary Processing (#298) * Flooring windowBound - offset. * Header boundary solved using scroll offset. * Footer solved. * Bug fix and doc updated. * Version bump. * Bounce scrolling recalculated on visible indices changed. * Boundary reached method moved to object. * Distance from window taken into consideration. * Adding distance from window to window bound. * Fix. * Reverting process end reached code. * Versions. * Styling. * Final Sticky Changes (#304) * import was not from web (#299) * CR changes. * Throwing exceptions for visibleIndexes and array sort. * Handling index 0 cases. * Updated doc with errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flooring
windowBound - lastOffsetwhile calculatingonEndReachedbecause sometimes value comes out as 0.000xx which doesn't send callback.