Sticky #261
Merged
Sticky #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ananyachandra14
commented
Oct 15, 2018
ananyachandra14
commented
- Sticky Headers and Footers
- Cascading sticky objects
- onVisibleIndexesChanged deprecated, onVisibleIndicesChanged to be used
added 13 commits
January 14, 2019 15:07
|
Is this PR ready to merge? |
|
@gut4 Yea it's ready. We'll be merging it soon enough. |
* Flooring windowBound - offset. * Header boundary solved using scroll offset. * Footer solved. * Bug fix and doc updated. * Version bump. * Bounce scrolling recalculated on visible indices changed. * Boundary reached method moved to object. * Distance from window taken into consideration. * Adding distance from window to window bound. * Fix.
…into stickyView
naqvitalha
requested changes
Feb 8, 2019
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "recyclerlistview", | |||
| "version": "1.4.0-beta.15", | |||
| "version": "1.4.0-beta.16", | |||
There was a problem hiding this comment.
Change to 2.0.0 and some available beta
scripts/publish-local.sh
Outdated
| @@ -2,6 +2,8 @@ | |||
| set -e | |||
|
|
|||
| TARGET=$"/Users/talha.naqvi/Documents/Work/RLV-Demo/node_modules/recyclerlistview/dist" #target-path | |||
| #TARGET=$"/Users/ananya.chandra/Documents/ReactNativeRepos/ts-rex/node_modules/recyclerlistview/dist" #target-path | |||
src/core/RecyclerListView.tsx
Outdated
| this._virtualRenderer.attachVisibleItemsListener(this.props.onVisibleIndexesChanged!); | ||
| } | ||
| if (this.props.onVisibleIndexesChanged) { | ||
| console.warn(Messages.VISIBLE_INDEXES_CHANGED_DEPRECATED); //tslint:disable-line |
There was a problem hiding this comment.
throw exception instead
| import CustomError from "./exceptions/CustomError"; | ||
| import RecyclerListViewExceptions from "./exceptions/RecyclerListViewExceptions"; | ||
|
|
||
| export interface StickyContainerProps { |
* import was not from web (#299) * CR changes. * Throwing exceptions for visibleIndexes and array sort. * Handling index 0 cases. * Updated doc with errors.
naqvitalha
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.