Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to the Databricks bring-your-own-warehouse series: #8700, #8703, Flagsmith/warehouse-delivery#16 and the
Databricks frontend PR (not yet open).
experimentation/connect-databrickspage: requirements, setup steps, secret rotation and troubleshooting.connect-a-warehouse: results now come from the connected ClickHouse (since feat(experimentation): read experiment results and exposures through the environment's warehouse #8683), a Databricks section links to thenew page, and Databricks is out of "Coming soon".
index: mentions bringing your own ClickHouse or Databricks.create-metrics: at-least-once delivery note.databricksSetupSql.ts, so the frontend PR must merge first.warehouse-databricks-form.png), to be captured.Open points:
principal probably had Can manage.
yet. Follow-up: confirm the static egress IPs for the API task processor and warehouse-delivery, publish them, then
document IP allow-listing for ClickHouse and Databricks.
Follow-up: confirm the behaviour and either support it or document it.
Merge only when API #8703, warehouse-delivery
feat/databricks-deliveryand the frontend PR are deployed to production, anddatabricks_warehouseexists in production and is on for at least one organisation.How did you test this code?
make lintindocs/: changed files pass prettier (166 untouched files already fail on main); build passes.getDatabricksSetupSql(); the parity test enforces it once the frontend PR is merged.