Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/databricks-warehouse-provider #8703 +/- ##
====================================================================
Coverage 98.85% 98.86%
====================================================================
Files 1668 1669 +1
Lines 69013 69332 +319
====================================================================
+ Hits 68223 68542 +319
Misses 790 790 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…s-warehouse-connection
|
@themis-blindfold review |
⚖️ Themis review: ✅ Ship itTL;DR: The Databricks provider is correctly registered, feature-gated at the connection API, and follows the existing warehouse read, verification, caching, and error-reporting paths. The completed API unit suites and documentation checks passed; no blocking review issues found.
📝 Walkthrough
🧪 How to verify
Product take: Solid capability expansion for customers running experimentation data in Databricks. The targeted flag makes the rollout appropriately controlled. 🧭 Assumptions & unverified claimsNo unverified assumptions or claims. Databricks joins the warehouse club without upsetting the query bouncer. · reviewed at e3de701 |
docs/if required so people know about the feature.Changes
Second half of the Databricks provider, stacked on #8700 (the statement client). Adds Databricks as a bring-your-own warehouse for experiment results, behind the
databricks_warehouseflag.DatabricksWarehouse: config and credentials validation, verify, event name and stats lookups, exposure buckets and results, over the client from feat(experimentation): add a Databricks statement client #8700.host,workspace_id,region,warehouse_id,catalog,schema(defaultflagsmith_exp). Pasted URLs and HTTP paths are normalised, and the workspace ID can come from a pasted?o=URL. Verify checks the workspace ID against thex-databricks-org-idresponse header.DatabricksDialectplugs into the sharedResultsQueryBuilder. Time buckets don't depend on the session timezone.0017adds the warehouse type. Thedatabricks_warehouseflag gates creating a Databricks connection, switching an existing one to it, and testing unsaved Databricks details.How did you test this code?
Unit tests cover the provider, dialect, serializers and views at 100% diff coverage, including the expected SQL for every query.
Live QA against a Databricks trial workspace, using the same events as a ClickHouse baseline: 18/18 API calls returned identical results. A wrong workspace ID was also checked live.
Separately, the warehouse-delivery work ran a pipeline (ingestion → Kafka → Zerobus) into the trial workspace, then
compute_experiment_exposuresandcompute_experiment_resultson an earlier revision of this branch, without the two review fixes. The computed totals matched the generated data. The results API endpoint was not exercised over pipeline-delivered rows.