Skip to content

chore(evaluation-context): Remove extra fields, clarify key semantics #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 4 commits into from
Oct 24, 2025
Merged

chore(evaluation-context): Remove extra fields, clarify key semantics #6176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
011403b
chore(evaluation-context): Remove extra fields, clarify `key` semantics
khvn26 Oct 20, 2025
da8ddf2
cleanup
khvn26 Oct 21, 2025
c6bc708
bring back environment key
khvn26 Oct 22, 2025
095643b
make identity key not required
khvn26 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions sdk/evaluation-context.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
"description": "Represents an environment context for feature flag evaluation.",
"properties": {
"key": {
"description": "An environment's unique identifier.",
"description": "Unique environment key. May be used for selecting a value for a multivariate feature, or for % split segmentation.",
"title": "Key",
"type": "string",
"x-flagsmith-engine-condition-property": "$.environment.key"
"type": "string"
},
"name": {
"description": "An environment's human-readable name.",
Expand All @@ -27,15 +26,10 @@
"description": "Represents a feature context for feature flag evaluation.",
"properties": {
"key": {
"description": "Key used when selecting a value for a multivariate feature. Set to an internal identifier or a UUID, depending on Flagsmith implementation.",
"description": "Unique feature key used when selecting a variant if the feature is multivariate. Set to an internal identifier or a UUID, depending on Flagsmith implementation.",
"title": "Key",
"type": "string"
},
"feature_key": {
"description": "Unique feature identifier.",
"title": "Feature Key",
"type": "string"
},
"name": {
"description": "Feature name.",
"title": "Name",
Expand Down Expand Up @@ -78,7 +72,6 @@
},
"required": [
"key",
"feature_key",
"name",
"enabled",
"value"
Expand Down Expand Up @@ -122,7 +115,7 @@
"description": "Represents an identity context for feature flag evaluation.",
"properties": {
"identifier": {
"description": "A unique identifier for an identity, used for segment and multivariate feature flag targeting, and displayed in the Flagsmith UI.",
"description": "A unique identifier for an identity as displayed in the Flagsmith UI.",
"title": "Identifier",
"type": "string",
"x-flagsmith-engine-condition-property": "$.identity.identifier"
Expand All @@ -148,8 +141,7 @@
}
},
"required": [
"identifier",
"key"
"identifier"
],
"title": "IdentityContext",
"type": "object"
Expand All @@ -158,7 +150,7 @@
"description": "Represents a segment context for feature flag evaluation.",
"properties": {
"key": {
"description": "Key used for % split segmentation.",
"description": "Unique segment key used for % split segmentation.",
"title": "Key",
"type": "string"
},
Expand Down
12 changes: 0 additions & 12 deletions sdk/evaluation-result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
"$defs": {
"FlagResult": {
"properties": {
"feature_key": {
"description": "Unique feature identifier.",
"title": "Feature Key",
"type": "string"
},
"name": {
"description": "Feature name.",
"title": "Name",
Expand Down Expand Up @@ -40,7 +35,6 @@
}
},
"required": [
"feature_key",
"name",
"enabled",
"value",
Expand All @@ -51,11 +45,6 @@
},
"SegmentResult": {
"properties": {
"key": {
"description": "Unique segment identifier.",
"title": "Key",
"type": "string"
},
"name": {
"description": "Segment name.",
"title": "Name",
Expand All @@ -69,7 +58,6 @@
}
},
"required": [
"key",
"name"
],
"title": "SegmentResult",
Expand Down
Loading