chore(evaluation-context): Remove extra fields, clarify key semantics
#6176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Zaimwa9
previously requested changes
Oct 21, 2025
Contributor
Docker builds report
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This was referenced Oct 22, 2025
gagantrivedi
approved these changes
Oct 23, 2025
Member
Author
|
I'm not merging this before Flagsmith/flagsmith-java-client#184 is merged since the latter relies heavily on code generation. |
khvn26
dismissed
Zaimwa9’s stale review
The outstanding comment was addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Closes #6192.
In this PR, we:
FeatureContext.feature_key. Engine implementations should now useFeatureContext.nameto match overrides.FlagResult.feature_key.SegmentResult.keyas segment metadata is now used by SDKs to present the segment IDs inget_segment_resultreturn values.keyfields.How did you test this code?
engine-test-data PR: Flagsmith/engine-test-data#33