Do removals in snapshot generation after all other actions. [STU3] #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes-in-snapshot-generator
marcovisserFurore
requested changes
Sep 7, 2022
| [TestMethod] | ||
| public async T.Task TestMergingAPreviouslyRemovedElement() | ||
| { | ||
| var baseStructureDefinition = new StructureDefinition() |
There was a problem hiding this comment.
To prevent large unit test files, it would be better to add these profiles to the folder TestData and use them here. You can use then the already existing _testResolver as well.
…ix-removal-of-derived-types-in-snapshot-generator
marcovisserFurore
approved these changes
Sep 7, 2022
marcovisserFurore
deleted the
bugfix/2211-fix-removal-of-derived-types-in-snapshot-generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2211