Skip to content

fix(generate_script): fallback to auto mode on invalid custom_script #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fancyboi999 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(generate_script): fallback to auto mode on invalid custom_script #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 30 additions & 28 deletions src/open_storyline/nodes/core_nodes/generate_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,34 +73,36 @@ async def process(self, node_state: NodeState, inputs: Dict[str, Any]) -> Any:
})

custom_script = {"group_scripts": group_scripts, "title": custom_script.get('title', '')}
return custom_script
except Exception as e:
node_state.node_summary.info_for_llm(f"generate script failed: {type(e).__name__}: {e}")
group_text_map = {}
return custom_script

else:
groups_block = _build_groups_block_for_script(groups, duration_lookup, caption_lookup)

system_prompt = get_prompt("generate_script.system", lang=node_state.lang)
if not user_request or user_request == "":
user_request = "No requirements"
user_prompt = get_prompt("generate_script.user", lang=node_state.lang, user_request=user_request, overall=overall, groups=groups_block)

raw = await llm.complete(
system_prompt=system_prompt,
user_prompt=user_prompt,
temperature=0.1,
top_p=0.9,
max_tokens=4096,
model_preferences=None,
)
group_text_map: dict[str, str] = {}
try:
obj = parse_json_dict(raw)
group_text_map = _extract_group_text_map(obj, group_ids)
except Exception as e:
node_state.node_summary.info_for_llm(f"generate script failed: {type(e).__name__}: {e}")
group_text_map = {}
node_state.node_summary.info_for_user("custom_script format is invalid, fallback to auto generation.")

groups_block = _build_groups_block_for_script(groups, duration_lookup, caption_lookup)

system_prompt = get_prompt("generate_script.system", lang=node_state.lang)
if not user_request or user_request == "":
user_request = "No requirements"
user_prompt = get_prompt("generate_script.user", lang=node_state.lang, user_request=user_request, overall=overall, groups=groups_block)

raw = await llm.complete(
system_prompt=system_prompt,
user_prompt=user_prompt,
temperature=0.1,
top_p=0.9,
max_tokens=4096,
model_preferences=None,
)
group_text_map: dict[str, str] = {}
script_title = ""
try:
obj = parse_json_dict(raw)
group_text_map = _extract_group_text_map(obj, group_ids)
if isinstance(obj, dict):
script_title = str(obj.get("title", "") or "")
except Exception as e:
node_state.node_summary.info_for_llm(f"generate script failed: {type(e).__name__}: {e}")
group_text_map = {}

group_scripts: list[dict[str, Any]] = []
subtitle_index = 1
Expand Down Expand Up @@ -139,7 +141,7 @@ async def process(self, node_state: NodeState, inputs: Dict[str, Any]) -> Any:

return {
"group_scripts": group_scripts,
"title": obj.get("title", ""),
"title": script_title,
}

def _build_duration_lookup(clip_info: list[dict[str, Any]]) -> dict[str, float]:
Expand Down Expand Up @@ -344,4 +346,4 @@ def validate_subtitle_format(data: dict[str, Any]):
if "group_id" not in group:
raise ValueError("group missing field 'group_id'")
if "raw_text" not in group:
raise ValueError("group missing field 'raw_text'")
raise ValueError("group missing field 'raw_text'")