fix(generate_script): fallback to auto mode on invalid custom_script#9
Open
fancyboi999 wants to merge 1 commit intoFireRedTeam:mainfrom
Open
fix(generate_script): fallback to auto mode on invalid custom_script#9fancyboi999 wants to merge 1 commit intoFireRedTeam:mainfrom
fancyboi999 wants to merge 1 commit intoFireRedTeam:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_scripthandling ingenerate_scriptcustom_scriptformat validation fails, fallback to normal auto-generation path instead of returning invalid payloadscript_titlesafely from parsed JSON to keep return path deterministicWhy
Previously, invalid
custom_scriptinput could be returned directly, which propagates malformed structure to downstream nodes. This creates avoidable runtime instability.Changes
src/open_storyline/nodes/core_nodes/generate_script.pycustom_script: unchanged behavior (immediate return)custom_script: log and fallback to auto generationtitlethrough explicitscript_titledefaultValidation
python3 -m py_compile src/open_storyline/nodes/core_nodes/generate_script.pycustom_script-> fallback auto generationcustom_script-> no llm callScope