Skip to content

[ASOC-2016] update asset default version after creating a new asset version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[ASOC-2016] update asset default version after creating a new asset version #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions finite_state_sdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,34 @@ def create_asset(token, organization_context, business_unit_id=None, created_by_
response = send_graphql_query(token, organization_context, graphql_query, variables)
return response['data']

"""
Call updateAsset to set the defaultVersion to the newly created AssetVersion
"""
def update_asset(token, organization_context, asset_id, asset_version_id):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation for any functions in the SDK are auto-generated, so we need to update this to have the correct format (see other functions for examples)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think the parameters should be named parameters, and make it clear that it is setting the default version, e.g. default_version=

graphql_query = '''
mutation UpdateAssetMutation($input: UpdateAssetInput!) {
updateAsset(input: $input) {
id
name
defaultVersion {
id
}
versions {
id
}
}
}
'''

variables = {
"input": {
"id": asset_id,
"defaultVersion": asset_version_id
}
}

response = send_graphql_query(token, organization_context, graphql_query, variables)
return response['data']

def create_asset_version(token, organization_context, business_unit_id=None, created_by_user_id=None, asset_id=None, asset_version_name=None, product_id=None):
"""
Expand Down Expand Up @@ -246,6 +274,11 @@ def create_asset_version(token, organization_context, business_unit_id=None, cre
variables["input"]["ctx"]["products"] = product_id

response = send_graphql_query(token, organization_context, graphql_query, variables)

if response.ok:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: GraphQL return values can be HTTP "OK", but contain errors in the return value instead of "data". The send_graphql_query checks for this, and raises an exception with the errors if the response contains errors - I'll add a test for this, because the response is not a requests object, but the actual JSON that gets returned

asset_version_id = response['data']['createAssetVersion']['id']
update_asset(token, organization_context, asset_id, asset_version_id)

return response['data']


Expand Down