[ASOC-2016] update asset default version after creating a new asset version #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvido
reviewed
Dec 18, 2023
| """ | ||
| Call updateAsset to set the defaultVersion to the newly created AssetVersion | ||
| """ | ||
| def update_asset(token, organization_context, asset_id, asset_version_id): |
There was a problem hiding this comment.
Documentation for any functions in the SDK are auto-generated, so we need to update this to have the correct format (see other functions for examples)
There was a problem hiding this comment.
Also, I think the parameters should be named parameters, and make it clear that it is setting the default version, e.g. default_version=
nickvido
reviewed
Dec 18, 2023
|
|
||
| response = send_graphql_query(token, organization_context, graphql_query, variables) | ||
|
|
||
| if response.ok: |
There was a problem hiding this comment.
Note: GraphQL return values can be HTTP "OK", but contain errors in the return value instead of "data". The send_graphql_query checks for this, and raises an exception with the errors if the response contains errors - I'll add a test for this, because the response is not a requests object, but the actual JSON that gets returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ASOC-2016
When creating a new AssetVersion, we now explicitly call UpdateAsset and set its defaultVersion to the new AssetVersion id in order to properly update that when using the SDK.