Skip to content

Modify surefire plugin failing test scope #674

Merged
cowtowncoder merged 2 commits intoFasterXML:2.18from
JooHyukKim:Modify-failing-test
Oct 11, 2024
Merged

Modify surefire plugin failing test scope #674
cowtowncoder merged 2 commits intoFasterXML:2.18from
JooHyukKim:Modify-failing-test

Conversation

@JooHyukKim
Copy link
Copy Markdown
Member

@JooHyukKim JooHyukKim commented Oct 10, 2024

We are starting to follow databind module's test structure and this is what databind module used to have.
We need current change for ..../records/failing test directory

Note : Ironically databind module went even further with recent failing test handling improvement , but we need to upgrade to JUnit 5 to achieve that.

Comment thread pom.xml Outdated
@@ -178,6 +178,7 @@ alternative support for serializing POJOs as XML and deserializing XML as pojos.
<configuration>
<excludes>
<exclude>com/fasterxml/jackson/dataformat/xml/failing/*.java</exclude>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove above line as redundant?

Copy link
Copy Markdown
Member Author

@JooHyukKim JooHyukKim Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

Removed

@cowtowncoder cowtowncoder merged commit eff8f8a into FasterXML:2.18 Oct 11, 2024
@JooHyukKim JooHyukKim deleted the Modify-failing-test branch October 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants