New failing test management using Jupiter extension#4696
New failing test management using Jupiter extension#4696cowtowncoder merged 10 commits intoFasterXML:2.18from
failing test management using Jupiter extension#4696Conversation
|
I think I like the idea of using annotation. The one last thing I feel uneasy about is the location: while in some ways it is good to keep tests in their logical place (where they'd be if passing), it makes it more difficult to see the set of expected-to-fail cases. So...
WDYT? I just like the ability to quickly see all tests that are for things-to-fix. |
|
Yeah it makes sense since when any test start passing, we need to further take actions. 'tofix' would suffice 😆. Will work on the revision within today |
cowtowncoder
left a comment
There was a problem hiding this comment.
Looks good -- but will probably wait until 2.19 branch started, after 2.18.0 release in a week or so.
…ooHyukKim/jackson-databind into resolve-jackson-243-discussion
|
Re-thinking this one: probably want to do for 2.18. Just need to see how to get things merged best way. |
|
Merged 3 new classes separately, went cleanly. Now tackling renaming which may get messier. |
|
Phew! That merge resolution was quite something. But this is now fully merged, for 2.18 and 3.0! |
Awww, thank u! 🙏🏽 Had I realized the work load, I would've done the merging into master. Please lemme know next time hehe @cowtowncoder |
|
@JooHyukKim Sure, not a problem. But I was in the best position to do the merge since I had renamed couple of tests, knew 2 pass in 3.0 but not 2.x... lots of trivia needed :) Also: I noticed there was one test (for issue #639 I think) duplicated so was able to delete that. |
This is from discussion regarding FasterXML/jackson#243 (reply in thread).
Descrption
jackson-databindseems like reasonable start since it is extended by most repos.On approval will do the following for closure ...
/testdirResources